Simplify permissions page logic #22850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes a bunch of outdated logic from the permissions page that is not in use anymore.
We previously stored the requested permissions alongside a boolean of whether they should be granted, but the option to toggle that boolean was removed years ago. This PR replaces that logic with deriving the requested permissions from the props without storing them in state. This also simplifies later iterations where the permission values (not just the keys) are needed to render the permissions.
Manual testing steps