Bump snaps packages and support dynamic interfaces - #22828
Conversation
FrederikBolding
added
the
team-snaps-deprecated
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore npm/@metamask/post-message-stream@8.0.0 Trusted authors and these were just published. |
252d9e7 to
4b2b380
Compare
FrederikBolding
changed the title
9728d45 to
9118389
Compare
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ccbbe45 to
be41c23
Compare
be41c23 to
086e3a4
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/ms@0.7.34, npm/cron-parser@4.9.0, npm/rfdc@1.3.1 |
cb99c32 to
f9bfe8f
Compare
There was a problem hiding this comment.
With the blessing of @brad-decker, I've deleted this story as it is broken due to circular dependencies.
|
@SocketSecurity ignore npm/@metamask/snaps-controllers@5.0.1 |
Builds ready [2405d1f]
Page Load Metrics (1062 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22828 +/- ##
===========================================
- Coverage 68.50% 68.46% -0.04%
===========================================
Files 1089 1089
Lines 43076 43107 +31
Branches 11480 11487 +7
===========================================
+ Hits 29507 29511 +4
- Misses 13569 13596 +27 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
## **Description** This PR integrates the necessary changes for interactive Interfaces. - Setup and update the various controllers. - Update the `SnapUIRenderer` to handle an `interfaceId` rather than direct content. - Add the logic for interface state and event handling in a new `InterfaceContext` react context. - Update the different APIs to handle the newly returned values. - Move the UI components mapping out of the `SnapUIRenderer` file - Rework confirmations to take the `SnapUIRenderer`. ## **Related issues** ## **Manual testing steps** 1. Fire up the interactive UI test snap [coming soon] 2. Play with the snap ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
0767d65
751bc5b to
0767d65
Compare
metamaskbot
added
the
release-11.12.0
Builds ready [0767d65]
Page Load Metrics (1995 ± 109 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ziedbrini
added
team-snaps-platform-deprecated
7 participants
Description
Bump snaps packages to latest and deals with breaking changes.
Summary of changes in the snaps deps:
snap_createInterfaceand updated withsnap_updateInterfacemaxRequestTimeto extend or shorten its execution timeoutDecompressionStreamfor improved installation performanceThis PR also contains #22795 merged in, which contains the integration for dynamic interfaces.
Related issues
Closes https://github.com/MetaMask/MetaMask-planning/issues/1954
Manual testing steps