Skip to content

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jan 29, 2024

Description

This PR creates a patch to check for all types of custodian keyrings that start with the prefix Custody

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Jan 29, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@montelaidev montelaidev added the team-accounts-framework Accounts Framework team label Jan 29, 2024
@montelaidev montelaidev changed the title fix: create patch for custody keyring in accoutns-controller fix: Create patch for custody keyring type in accounts controller Jan 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bfffa68]
Page Load Metrics (772 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91145111157
domContentLoaded9351873
load6839247726531
domInteractive9351873
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 40 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e166b7) 68.00% compared to head (bfffa68) 68.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22692   +/-   ##
========================================
  Coverage    68.00%   68.00%           
========================================
  Files         1088     1088           
  Lines        42871    42871           
  Branches     11390    11390           
========================================
  Hits         29152    29152           
  Misses       13719    13719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@montelaidev montelaidev marked this pull request as ready for review January 29, 2024 13:07
@montelaidev montelaidev requested a review from a team as a code owner January 29, 2024 13:07
@shane-t shane-t self-requested a review January 29, 2024 13:10
@montelaidev montelaidev merged commit c45acd7 into develop Jan 29, 2024
@montelaidev montelaidev deleted the fix/patch-custody-for-accounts-controller branch January 29, 2024 14:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants