UX: Add event tracking for empty banner displays #22654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
force-pushed
the
1949-asset-list-event-tracking
branch
from
4ba64f8 to
0d3845e
Compare
darkwing
force-pushed
the
1949-asset-list-event-tracking
branch
from
d89aadb to
b73cc6e
Compare
NidhiKJha
previously approved these changes
Feb 1, 2024
Collaborator
Builds ready [d40792c]
Page Load Metrics (803 ± 26 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
reviewed
Feb 1, 2024
Comment on lines
+138
to
+150
| chain_id: currentNetwork.chainId, | ||
| locale: currentLocale, | ||
| network: currentNetwork.nickname, | ||
| referrer: ORIGIN_METAMASK, |
Contributor
There was a problem hiding this comment.
Nit: we can extract them to a property object and use it for different events tracked in this file
Contributor
Author
There was a problem hiding this comment.
I can do that in a follow up as it's not core and I do kind of like the context of what the nickname and chainId belong to!
darkwing
force-pushed
the
1949-asset-list-event-tracking
branch
from
d40792c to
93a3a68
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22654 +/- ##
===========================================
+ Coverage 68.47% 68.49% +0.02%
===========================================
Files 1089 1089
Lines 42905 42926 +21
Branches 11426 11429 +3
===========================================
+ Hits 29378 29400 +22
+ Misses 13527 13526 -1 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [93a3a68]
Page Load Metrics (818 ± 42 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
added
the
needs-assets-ux-review
NidhiKJha
approved these changes
Feb 8, 2024
vthomas13
approved these changes
Feb 8, 2024
metamaskbot
added
the
release-11.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds event tracking for the new "Buy", "Receive", and "NFT" banners.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1949
Manual testing steps
ui/contexts/metametrics.jsand in thetrackEventfunction, add aconsole.logto see the events get recorded (or use Logpoints in the debugger)Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist