-
Notifications
You must be signed in to change notification settings - Fork 5.4k
remove unused notification data #21533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
You can go further, if you want to. Every notification from 1 to 22 (except 8 and 20) is dead. |
746742b to
9117cbd
Compare
9117cbd to
a3cd91c
Compare
aa43e84 to
409d204
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21533 +/- ##
===========================================
+ Coverage 68.44% 68.53% +0.09%
===========================================
Files 1052 1045 -7
Lines 41767 41616 -151
Branches 11135 11082 -53
===========================================
- Hits 28584 28520 -64
+ Misses 13183 13096 -87 ☔ View full report in Codecov by Sentry. |
0699ac6 to
b29dfd6
Compare
11e3276 to
1a808ac
Compare
05fc655 to
7d2fc5b
Compare
ea818b3 to
173f3ab
Compare
173f3ab to
5089d2c
Compare
5089d2c to
db2c7ca
Compare
db2c7ca to
242545e
Compare
In the interest of minimizing review overhead and potential time-to-merge, I think this can be kept to one, and further removals can be submitted separately |
a790cda to
e4563f0
Compare
e4563f0 to
ac2b70f
Compare
1ac21e9 to
f1ed0ad
Compare
f1ed0ad to
87faf94
Compare
## **Description** Continues the work that @legobeat was doing in #20703 and #21533 All old numbered notifications except 8, 20, and 24 were permanently turned off, but their code, their `messages.json`, and most importantly their images were still present in the Extension. By removing all this, we reduce the size of the zipped Extension by 949kB, and the unzipped Extension by 1,852kB. **IMPORTANT**: This is **NOT** well-tested from a QA perspective, and QA should do some good testing on it before we merge. ## **Related issues** Followup to: #20703 Followup to: #21533 --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
|
Closed because superseded by #22678 |
Description
Free up 250kB of bundle data by removing unused static asset.
This is the first of a series of removals.
Past discussion and further context: #20703 (review)
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist