Skip to content

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 25, 2023

Description

Free up 250kB of bundle data by removing unused static asset.

This is the first of a series of removals.

Past discussion and further context: #20703 (review)

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@HowardBraham
Copy link
Contributor

You can go further, if you want to. Every notification from 1 to 22 (except 8 and 20) is dead.

@legobeat legobeat force-pushed the remove-swaps-redesign-image branch from 746742b to 9117cbd Compare October 25, 2023 18:15
@legobeat legobeat added the team-application-security Application security team label Oct 25, 2023
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch from 9117cbd to a3cd91c Compare October 26, 2023 00:25
@legobeat legobeat marked this pull request as ready for review October 26, 2023 00:25
@legobeat legobeat requested a review from a team as a code owner October 26, 2023 00:25
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch 5 times, most recently from aa43e84 to 409d204 Compare November 1, 2023 23:13
@codecov
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1984f31) 68.44% compared to head (1a808ac) 68.53%.

❗ Current head 1a808ac differs from pull request most recent head 05fc655. Consider uploading reports for the commit 05fc655 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21533      +/-   ##
===========================================
+ Coverage    68.44%   68.53%   +0.09%     
===========================================
  Files         1052     1045       -7     
  Lines        41767    41616     -151     
  Branches     11135    11082      -53     
===========================================
- Hits         28584    28520      -64     
+ Misses       13183    13096      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the remove-swaps-redesign-image branch 2 times, most recently from 0699ac6 to b29dfd6 Compare November 7, 2023 22:03
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch from 11e3276 to 1a808ac Compare November 10, 2023 00:55
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch 2 times, most recently from 05fc655 to 7d2fc5b Compare November 22, 2023 11:37
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch from ea818b3 to 173f3ab Compare November 30, 2023 12:03
@legobeat legobeat requested a review from a team November 30, 2023 12:03
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch from 173f3ab to 5089d2c Compare December 25, 2023 23:09
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch from 5089d2c to db2c7ca Compare January 11, 2024 02:45
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch from db2c7ca to 242545e Compare January 18, 2024 10:57
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 22, 2024
@legobeat
Copy link
Contributor Author

You can go further, if you want to. Every notification from 1 to 22 (except 8 and 20) is dead.

In the interest of minimizing review overhead and potential time-to-merge, I think this can be kept to one, and further removals can be submitted separately

@legobeat legobeat requested a review from davidmurdoch February 8, 2024 08:55
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch 2 times, most recently from 1ac21e9 to f1ed0ad Compare February 8, 2024 15:51
@legobeat legobeat force-pushed the remove-swaps-redesign-image branch from f1ed0ad to 87faf94 Compare February 8, 2024 20:52
HowardBraham added a commit that referenced this pull request Feb 13, 2024
## **Description**

Continues the work that @legobeat was doing in #20703 and #21533

All old numbered notifications except 8, 20, and 24 were permanently
turned off, but their code, their `messages.json`, and most importantly
their images were still present in the Extension.

By removing all this, we reduce the size of the zipped Extension by
949kB, and the unzipped Extension by 1,852kB.

**IMPORTANT**: This is **NOT** well-tested from a QA perspective, and QA
should do some good testing on it before we merge.

## **Related issues**

Followup to: #20703
Followup to: #21533

---------

Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
@HowardBraham
Copy link
Contributor

Closed because superseded by #22678

@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template team-application-security Application security team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants