[FLASK] Transaction Insights V2 Integration #20554

hmalik88 · 2023-08-22T15:04:38Z

Transaction Insights V2 Integration. This PR implements the spec outlined in SIP-11. The way we capture analytics is also changed slightly as a result of how we fetch data (eagerly) in v2.

Screen.Recording.2023-09-18.at.9.25.46.PM.mov

github-actions · 2023-08-22T15:04:51Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/components/app/confirm-page-container/confirm-page-container.component.js

metamaskbot · 2023-09-01T16:46:12Z

Builds ready [41c60f8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1680 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	115	191	146	22	11
		domContentLoaded	1524	1868	1679	96	46
		load	1525	1869	1680	96	46
		domInteractive	1524	1868	1679	96	46

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.35 KiB (0.02%)
common: 783 Bytes (0.02%)

codecov · 2023-09-01T16:46:22Z

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (82ceffb) 68.84% compared to head (35b2df2) 68.86%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #20554      +/-   ##
===========================================
+ Coverage    68.84%   68.86%   +0.02%     
===========================================
  Files         1039     1039              
  Lines        41403    41428      +25     
  Branches     11058    11055       -3     
===========================================
+ Hits         28501    28527      +26     
+ Misses       12902    12901       -1

Files	Coverage Δ
shared/constants/metametrics.ts	`100.00% <100.00%> (ø)`
ui/selectors/permissions.js	`62.00% <100.00%> (+1.58%)`	⬆️
ui/selectors/selectors.js	`86.68% <100.00%> (+0.04%)`	⬆️
app/scripts/metamask-controller.js	`55.71% <33.33%> (+0.47%)`	⬆️
ui/store/actions.ts	`43.02% <0.00%> (-0.08%)`	⬇️
...page-container/confirm-page-container.component.js	`68.92% <58.82%> (+0.07%)`	⬆️
ui/hooks/useTransactionInsights.js	`50.00% <30.43%> (-4.17%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-10-23T18:58:15Z

Builds ready [8111abd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1261 ± 460 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	169	121	24	11
		domContentLoaded	71	143	110	22	10
		load	83	2407	1261	959	460
		domInteractive	71	143	110	22	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 49 Bytes (0.00%)
ui: 2.54 KiB (0.03%)
common: 783 Bytes (0.02%)

ui/components/app/confirm-page-container/snaps/snap-insight.js

ui/hooks/snaps/useTransactionInsightSnaps.js

ui/components/app/snaps/tx-insight-warnings/tx-insight-warnings.js

metamaskbot · 2023-10-31T20:58:53Z

Builds ready [2468d61]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1288 ± 337 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	81	99	89	6	3
		domContentLoaded	66	94	82	9	4
		load	76	1830	1288	702	337
		domInteractive	66	94	82	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 49 Bytes (0.00%)
ui: 2.54 KiB (0.03%)
common: 783 Bytes (0.02%)

metamaskbot · 2023-11-01T10:47:55Z

Builds ready [221c2ca]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1524 ± 346 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	168	109	22	11
		domContentLoaded	78	162	103	20	10
		load	78	2251	1524	720	346
		domInteractive	78	162	103	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 49 Bytes (0.00%)
ui: 2.77 KiB (0.03%)
common: 783 Bytes (0.02%)

metamaskbot · 2023-11-01T22:49:19Z

Builds ready [35b2df2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1420 ± 322 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	119	94	8	4
		domContentLoaded	69	102	88	8	4
		load	80	1973	1420	671	322
		domInteractive	69	102	88	8	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 49 Bytes (0.00%)
ui: 2.77 KiB (0.03%)
common: 783 Bytes (0.02%)

FrederikBolding

~~When sending ETH this doesn't seem to prompt me with the modal.~~

added warning logic for tx insight v2 integration

92688c9

hmalik88 added 8 commits August 22, 2023 11:39

spelling fix

db6977a

create tx insight warning component

c07bcca

Merge branch 'develop' into hm/tx-insight-v2

1d3dedc

finish warnings modal

80d5326

Merge branch 'develop' into hm/tx-insight-v2

7603363

fixed some errors

35d8b9b

copy & styling updates, moved warning modal appearance

54ec61a

Merge branch 'develop' into hm/tx-insight-v2

d78bccc

FrederikBolding reviewed Aug 31, 2023

View reviewed changes

ui/components/app/confirm-page-container/confirm-page-container.component.js Outdated Show resolved Hide resolved

FrederikBolding and others added 6 commits August 31, 2023 11:59

Fix a few issues during testing

0d32590

fix some errors

1be1920

fix warning onClick function & state

b1ff7cb

make adjustments to allow for single insight fetching in stable

b8c8370

Merge branch 'develop' into hm/tx-insight-v2

a654f81

add some more fencing

ddc8fbb

hmalik88 added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Sep 1, 2023

hmalik88 added 6 commits September 1, 2023 10:54

remove empty css file

126e046

lint fix

9d77641

remove comment

c7bfaeb

add more fencing

78c5cbd

fix fencing

fbf8c98

another fencing fix

41c60f8

hmalik88 marked this pull request as ready for review September 1, 2023 16:49

hmalik88 requested review from a team as code owners September 1, 2023 16:49

Merge branch 'develop' into hm/tx-insight-v2

ac83df0

hmalik88 added 7 commits October 23, 2023 09:17

Merge branch 'develop' into hm/tx-insight-v2

745eb15

fencing fix

a714020

Merge branch 'develop' into hm/tx-insight-v2

b3a9716

more fencing

1ccc4a6

more & more fencing

f28daf1

update hook

6d084c6

var assignment fix

8111abd

FrederikBolding reviewed Oct 27, 2023

View reviewed changes

ui/components/app/confirm-page-container/snaps/snap-insight.js Show resolved Hide resolved

ui/hooks/snaps/useTransactionInsightSnaps.js Show resolved Hide resolved

ui/components/app/snaps/tx-insight-warnings/tx-insight-warnings.js Show resolved Hide resolved

hmalik88 added 4 commits October 27, 2023 09:23

Merge branch 'develop' into hm/tx-insight-v2

d409435

Merge branch 'develop' into hm/tx-insight-v2

c3ae276

center div =^.^=

5a3398c

Merge branch 'develop' into hm/tx-insight-v2

2468d61

FrederikBolding added 2 commits November 1, 2023 10:40

Fix some state management issues

3ed9d85

Fix lint

221c2ca

hmalik88 added 5 commits November 1, 2023 08:15

Merge branch 'develop' into hm/tx-insight-v2

8abb832

styling adjustments

e9e754e

update snapshot

c81601c

Merge branch 'develop' into hm/tx-insight-v2

eee827f

update another snapshot

35b2df2

FrederikBolding requested changes Nov 2, 2023

View reviewed changes

FrederikBolding approved these changes Nov 2, 2023

View reviewed changes

GuillaumeRx approved these changes Nov 6, 2023

View reviewed changes

hmalik88 merged commit af6816f into develop Nov 6, 2023
64 checks passed

hmalik88 deleted the hm/tx-insight-v2 branch November 6, 2023 15:11

github-actions bot locked and limited conversation to collaborators Nov 6, 2023

metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLASK] Transaction Insights V2 Integration #20554

[FLASK] Transaction Insights V2 Integration #20554

hmalik88 commented Aug 22, 2023 •

edited

Loading

github-actions bot commented Aug 22, 2023

metamaskbot commented Sep 1, 2023

codecov bot commented Sep 1, 2023 •

edited

Loading

metamaskbot commented Oct 23, 2023

metamaskbot commented Oct 31, 2023

metamaskbot commented Nov 1, 2023

metamaskbot commented Nov 1, 2023

FrederikBolding left a comment •

edited

Loading

[FLASK] Transaction Insights V2 Integration #20554

[FLASK] Transaction Insights V2 Integration #20554

Conversation

hmalik88 commented Aug 22, 2023 • edited Loading

github-actions bot commented Aug 22, 2023

metamaskbot commented Sep 1, 2023

codecov bot commented Sep 1, 2023 • edited Loading

Codecov Report

metamaskbot commented Oct 23, 2023

metamaskbot commented Oct 31, 2023

metamaskbot commented Nov 1, 2023

metamaskbot commented Nov 1, 2023

FrederikBolding left a comment • edited Loading

Choose a reason for hiding this comment

hmalik88 commented Aug 22, 2023 •

edited

Loading

codecov bot commented Sep 1, 2023 •

edited

Loading

FrederikBolding left a comment •

edited

Loading