Closed
Conversation
Ganache RPC methods can now be used in e2e tests. These methods allow greater control over when blocks are mined, letting us eliminate race conditions in our tests related to block time. They also make it easier to adjust blockchain state, such as account nonce and balance.
Member
Author
|
These methods aren't used anywhere yet, but I'm working on a test for #18129 that I wanted to use |
Collaborator
Builds ready [2ccf78b]
Page Load Metrics (1653 ± 69 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
8 tasks
Member
Member
Author
|
Absolutely! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ganache RPC methods can now be used in e2e tests. These methods allow greater control over when blocks are mined, letting us eliminate race conditions in our tests related to block time. They also make it easier to adjust blockchain state, such as account nonce and balance.
See here for more information on these methods: https://ganache.dev/#evm_addAccount
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.