Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 18, 2023

Explanation

Bumps Snaps packages to 0.28.0 and handles any breaking changes.

@FrederikBolding FrederikBolding marked this pull request as ready for review January 23, 2023 12:33
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 23, 2023 12:33
@metamaskbot
Copy link
Collaborator

Builds ready [af52878]
Page Load Metrics (1322 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint98173129189
domContentLoaded101919111297230111
load107919111322236113
domInteractive101919111297230111
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2039 bytes
  • ui: 0 bytes
  • common: 0 bytes

Mrtenz
Mrtenz previously approved these changes Jan 23, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [4d08d54]
Page Load Metrics (1261 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint881911152211
domContentLoaded99217051252249119
load101017051261255122
domInteractive99217051252249119
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2039 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov-commenter
Copy link

Codecov Report

Merging #17277 (4d08d54) into develop (cb12cb8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #17277      +/-   ##
===========================================
- Coverage    60.06%   60.05%   -0.01%     
===========================================
  Files          936      934       -2     
  Lines        36049    36031      -18     
  Branches      9278     9274       -4     
===========================================
- Hits         21652    21636      -16     
+ Misses       14397    14395       -2     
Impacted Files Coverage Δ
app/scripts/metamask-controller.js 60.49% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@FrederikBolding FrederikBolding merged commit 51518c4 into develop Jan 23, 2023
@FrederikBolding FrederikBolding deleted the snaps-monorepo@0.28.0 branch January 23, 2023 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants