-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure prod beta build is created when merging to master #16557
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One suggestion to improve a step name though.
Builds ready [32fef17]
Page Load Metrics (2309 ± 101 ms)
Bundle size diffs
|
Also, we should make the same change for the Flask builds (though that does not need to be in this PR) |
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Builds ready [a0a4f87]
Page Load Metrics (2164 ± 134 ms)
Bundle size diffs
|
Currently, the builds generated by the
prep-build-beta
step of CI only produce development builds. This PR ensures that prod builds are created by that step when merging to master