Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure prod beta build is created when merging to master #16557

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Nov 17, 2022

Currently, the builds generated by the prep-build-beta step of CI only produce development builds. This PR ensures that prod builds are created by that step when merging to master

@danjm danjm requested review from a team and kumavis as code owners November 17, 2022 16:02
@danjm danjm requested a review from jpuri November 17, 2022 16:02
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

.circleci/config.yml Outdated Show resolved Hide resolved
Gudahtt
Gudahtt previously approved these changes Nov 17, 2022
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One suggestion to improve a step name though.

.circleci/config.yml Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [32fef17]
Page Load Metrics (2309 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94154119157
domContentLoaded184826002289207100
load184826292309209101
domInteractive184826002289207100
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@Gudahtt
Copy link
Member

Gudahtt commented Nov 17, 2022

Also, we should make the same change for the Flask builds (though that does not need to be in this PR)

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@metamaskbot
Copy link
Collaborator

Builds ready [a0a4f87]
Page Load Metrics (2164 ± 134 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982159238444213
domContentLoaded175125992143275132
load177626932164279134
domInteractive175125992143275132
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@danjm danjm merged commit 27e8f0f into develop Nov 17, 2022
@danjm danjm deleted the beta-prod-build-config branch November 17, 2022 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants