Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta: Update long logo to new imagery #16505

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Beta: Update long logo to new imagery #16505

merged 2 commits into from
Nov 16, 2022

Conversation

darkwing
Copy link
Contributor

@kevinghim requested a new long logo for beta, so here it is:

NewLogo

@darkwing darkwing requested a review from a team as a code owner November 15, 2022 15:25
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added the PR - P1 identifies PRs deemed priority for Extension team label Nov 15, 2022
@adonesky1
Copy link
Contributor

Should this be updating the existing horizontal logo or adding a separate beta logo?

@darkwing
Copy link
Contributor Author

Updating the existing beta logo in the switch statement.

Gudahtt
Gudahtt approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [9099c10]
Page Load Metrics (2043 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91147105126
domContentLoaded16492383202719694
load16492383204319192
domInteractive16492383202719694
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -1143 bytes
  • ui: -20 bytes
  • common: -664 bytes

highlights:

storybook

@darkwing darkwing merged commit 5fc186b into develop Nov 16, 2022
@darkwing darkwing deleted the beta-long-logo branch November 16, 2022 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@brad-decker brad-decker brad-decker approved these changes

@adonesky1 adonesky1 adonesky1 approved these changes

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy NiranjanaBinoy is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
PR - P1 identifies PRs deemed priority for Extension team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darkwing @adonesky1 @metamaskbot @Gudahtt @brad-decker