Skip to content

Conversation

@ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 1, 2022

Fixes: #16276

Also updates the casing of the "Learn more" text

Manual Testing Steps

  1. Unlock MM
  2. Connect to Test Dapp
  3. Open MM popup
  4. Click "Learn more" from the Connected account notification
  5. Ensure the user navigates to https://metamask.zendesk.com/hc/en-us/articles/4405506066331-User-guide-Dapps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@ryanml ryanml requested a review from a team as a code owner November 1, 2022 07:03
@ryanml ryanml self-assigned this Nov 1, 2022
@ryanml ryanml requested a review from jpuri November 1, 2022 07:03
@metamaskbot
Copy link
Collaborator

Builds ready [f621a10]
Page Load Metrics (2206 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint922921164220
domContentLoaded17722369218815072
load17722405220616378
domInteractive17722369218815072

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Aside: localisations are inconsistent on casing of learnMore where most languages have it with leading upper-case identical to learnMoreUpperCase (e.g. Spanish, French, German, Danish) and some don't (English, Turkish).

@ryanml ryanml merged commit d837250 into develop Nov 1, 2022
@ryanml ryanml deleted the fix-16276 branch November 1, 2022 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "learn more" link from Connected account notification is broken

5 participants