Skip to content

Conversation

@kumavis
Copy link
Member

@kumavis kumavis commented Nov 1, 2022

also includes a rename of the script to reflect its role

(before) yarn lavamoat:background:auto => 886.30s
(after) yarn lavamoat:webapp:auto => 96.69s

9.2x faster!
13 minutes faster!

@kumavis kumavis requested a review from a team as a code owner November 1, 2022 00:37
@kumavis kumavis requested a review from garrettbear November 1, 2022 00:37
@metamaskbot
Copy link
Collaborator

Builds ready [762e151]
Page Load Metrics (2125 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87130102136
domContentLoaded16622448209818388
load16812448212517986
domInteractive16622448209818388

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Wish we had thought of this sooner

@kumavis kumavis merged commit 9a74c99 into develop Nov 1, 2022
@kumavis kumavis deleted the lavamoat-gen-policy branch November 1, 2022 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants