Add data about dropped transaction in FINALIZED metrics event #15383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
brad-decker
suggested changes
Jul 29, 2022
…e tx that replaced it and delete getTransactionByHash method
VSaric
force-pushed
the
add-data-about-dropped-transaction
branch
from
03c5559 to
1c9525d
Compare
brad-decker
approved these changes
Aug 1, 2022
Collaborator
Builds ready [1c9525d]
Page Load Metrics (1731 ± 103 ms)
|
Collaborator
Builds ready [6b873e7]
Page Load Metrics (2498 ± 135 ms)
|
digiwand
approved these changes
Aug 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Based on this comment #15150 (comment), if there is a
TRANSACTION_EVENTS.FINALIZEDevent for a dropped transaction, we should track a propertytransaction_replacedthat can be one ofcancelorretryorother.We modified the
_markNonceDuplicatesDroppedfunction to, in addition to adding thereplacedBykey, adding areplacedByIdkey that records the internal metamask id of the tx that replaced it. Once we get thetxMetaof the transaction that is replacing the dropped transaction, then we can determinecancelorretryorotherusing thetypeinformation on the transaction (if it doesn't matchcancelorretrythen it isother).More Information
Screenshots/Screencaps
Before
After
Manual Testing Steps