Skip to content

Version v10.18.1 RC #15331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2022
Merged

Version v10.18.1 RC #15331

merged 3 commits into from
Jul 26, 2022

Conversation

@metamaskbot
Copy link
Collaborator

@metamaskbot metamaskbot commented Jul 22, 2022

📦 🚀

@danjm danjm marked this pull request as ready for review July 22, 2022 20:49
@danjm danjm requested a review from a team as a code owner July 22, 2022 20:49
@danjm danjm requested a review from digiwand July 22, 2022 20:49
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm
Metrics adjustments (#15313)
99f753d 
* Don't send errors to sentry if users have not opted-in to participate in metametrics

* Don't capture opt-out metrics

* Move the metrics-opt in screen to immediately after the welcome screen

* Ensure that global.getSentryState is set in the background

* Fix e2e tests after rearranging onboardin flow

* Fix unit tests

* More e2e test fixes

* Remove unnecessary wrappers around capture exception
@metamaskbot
Copy link
Collaborator Author

metamaskbot commented Jul 22, 2022

Builds ready [99f753d]
Page Load Metrics (1836 ± 159 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint832420230504242
domContentLoaded161027161829330158
load161027161836332159
domInteractive161027161829330158

highlights:

storybook

@danjm danjm merged commit 0315a3d into master Jul 26, 2022
@danjm danjm deleted the Version-v10.18.1 branch July 26, 2022 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

+3 more reviewers

@darkwing darkwing darkwing approved these changes

@digiwand digiwand digiwand approved these changes

@PeterYinusa PeterYinusa PeterYinusa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@metamaskbot @darkwing @digiwand @adonesky1 @PeterYinusa @danjm