-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Ensure that editing a tx from a transfer to a simple send resets data and updates type #15248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2409c25
d934561
ef50c58
97745fa
9514f02
1eed22c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -745,7 +745,7 @@ export function updateEditableParams(txId, editableParams) { | |
| log.error(error.message); | ||
| throw error; | ||
| } | ||
|
|
||
| await forceUpdateMetamaskState(dispatch); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [q] why is this necessary?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To ensure that transaction state is properly updated before hitting the confirm screen routing logic after clicking the "Next" button |
||
| return updatedTransaction; | ||
| }; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows us to set txParams to empty strings