Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test proptype #14868

Merged
merged 5 commits into from
Jun 7, 2022
Merged

Unit test proptype #14868

merged 5 commits into from
Jun 7, 2022

Conversation

tmashuang
Copy link
Contributor

Explanation

Various prop fixes to unit tests. The one functional change is having the description prop in Settings be either a object or string.

More Information

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@tmashuang tmashuang requested a review from a team as a code owner June 6, 2022 16:09
@tmashuang tmashuang requested a review from digiwand June 6, 2022 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [76f8242]
Page Load Metrics (1873 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint801721032110
domContentLoaded157522471824211101
load157623551873213102
domInteractive157522471824211101

highlights:

storybook

@tmashuang tmashuang merged commit 18e4af7 into develop Jun 7, 2022
@tmashuang tmashuang deleted the unit-test-proptype branch June 7, 2022 02:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants