Reduce the default slippage from 3% to 2% #14863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
previously approved these changes
Jun 6, 2022
shared/constants/swaps.js
Outdated
| @@ -206,3 +206,5 @@ export const TOKEN_BUCKET_PRIORITY = { | |||
| OWNED: 'owned', | |||
| TOP: 'top', | |||
| }; | |||
|
|
|||
| export const DEFAULT_SLIPPAGE = 2; | |||
| @@ -40,16 +41,16 @@ export default function SlippageButtons({ | |||
| const [enteringCustomValue, setEnteringCustomValue] = useState(false); | |||
| const [activeButtonIndex, setActiveButtonIndex] = useState(() => { | |||
| if (currentSlippage === 3) { | |||
| return 1; | |||
| return 1; // 3% slippage. | |||
| } else if (currentSlippage === 2) { | |||
There was a problem hiding this comment.
Is there a way we can use the constant in this?
darkwing
previously approved these changes
Jun 7, 2022
adonesky1
reviewed
Jun 7, 2022
| }} | ||
| > | ||
| 2% | ||
| {`${SLIPPAGE.DEFAULT}%`} |
There was a problem hiding this comment.
Should we localize this? It seems like in persian and turkish the percentage sign comes first.
adonesky1
reviewed
Jun 7, 2022
Comment on lines
34
to
35
| currentSlippage !== SLIPPAGE.DEFAULT && | ||
| currentSlippage !== SLIPPAGE.HIGH |
There was a problem hiding this comment.
[nit]
Suggested change
| currentSlippage !== SLIPPAGE.DEFAULT && | |
| currentSlippage !== SLIPPAGE.HIGH | |
| !Object.values(SLIPPAGE).includes(currentSlippage) |
adonesky1
previously approved these changes
Jun 7, 2022
adonesky1
approved these changes
Jun 7, 2022
darkwing
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Reduce the default slippage from 3% to 2%.
Screenshots
Before:
After:
