Skip to content

Conversation

@danjm
Copy link
Contributor

@danjm danjm commented Apr 25, 2022

Fixes #14446

The network name being used in the message translation was undefined on non-default infura networks. This PR corrects that by pulling a name for the network from state, if our defaults are unavailable.

Before:
Screenshot from 2022-04-25 10-05-55

After:
Screenshot from 2022-04-25 10-03-58

In additon to the before/after screenshot, this PR makes the following error go away: Error: Insufficient number of substitutions for key "insufficientCurrency" with locale "en"

@danjm danjm requested a review from a team as a code owner April 25, 2022 12:37
@danjm danjm requested a review from ryanml April 25, 2022 12:37
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [bad81ba]
Page Load Metrics (1260 ± 35 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7914897199
domContentLoaded1187143512446531
load1187143512607335
domInteractive1187143512446531

highlights:

storybook

@danjm danjm merged commit 284bab1 into develop Apr 25, 2022
@danjm danjm deleted the fix-insufficientCurrencyBuyOrDeposit-warning branch April 25, 2022 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Insufficient number of substitutions for key "insufficientCurrency" with locale "en"

6 participants