refactor confirm-transaction component from class to functional #13789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctController to determine how to represent the contract being interacted with in token contract method calls
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
force-pushed
the
refactor-the-refactor
branch
3 times, most recently
from
a23960b to
a9b4d1b
Compare
adonesky1
force-pushed
the
refactor-the-refactor
branch
2 times, most recently
from
1a76353 to
cad8876
Compare
Contributor
Author
|
Very stale. probably not worth it at this point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Originally part of larger refactor (#13131), extracted out because it is not necessary to the core of that work, and may distract from the core changes (new trimmed down version here: #13788).
confirm-transaction.js- from class to functional (includes providing all required redux state/methods via selectors/dispatch, and changing lifecycle methods touseEffect) while preserving all functionality.