Skip to content

Conversation

@ryanml
Copy link
Contributor

@ryanml ryanml commented Feb 15, 2022

Test Plan:

  1. Connect an account to https://metamask.github.io/test-dapp/
  2. Initiate a Sign Typed Data V3 signature
  3. Ensure the sign can be completed without issue
  4. Initiate a Sign Typed Data V4 signature
  5. Ensure the "Sign" button is disabled
  6. Ensure that the message content area is scrollable
  7. Confirm that the "Sign" button becomes enabled once the content area is scrolled through
sign-typed.mov

@ryanml ryanml requested a review from a team as a code owner February 15, 2022 17:20
@ryanml ryanml self-assigned this Feb 15, 2022
@ryanml ryanml requested review from adonesky1 and danjm February 15, 2022 17:20
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

danjm
danjm previously approved these changes Feb 15, 2022
@danjm danjm force-pushed the signed-data-format-fixes branch from f3220dc to 79623f7 Compare February 15, 2022 17:57
@metamaskbot
Copy link
Collaborator

Builds ready [79623f7]
Page Load Metrics (1132 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671169303319153
domContentLoaded1071131611325828
load1071131611325828
domInteractive1071131611325828

highlights:

storybook

@ryanml ryanml merged commit 40269ad into develop Feb 15, 2022
@ryanml ryanml deleted the signed-data-format-fixes branch February 15, 2022 18:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants