Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "#10168 - Fix to Can't open settings if browser zoom level > 100%" #13459

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Revert "#10168 - Fix to Can't open settings if browser zoom level > 100%" #13459

merged 1 commit into from
Jan 28, 2022

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jan 28, 2022 •
edited
Loading

Reverts #13281

Reverting this PR because it created a new bug which pushes the content down when the media screen width is (max-width: $break-small):

Follow-up fix for issue is here: #13460

@digiwand digiwand requested a review from a team as a code owner January 28, 2022 19:13
@digiwand digiwand requested a review from PeterYinusa January 28, 2022 19:13
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4af368d]
Page Load Metrics (1384 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711297415421202
domContentLoaded109517021382211102
load109617021384212102
domInteractive109517021382211102

highlights:

storybook

@digiwand digiwand mentioned this pull request Jan 28, 2022
Merged
@digiwand digiwand requested review from Gtonizuka and ryanml January 28, 2022 20:57
@digiwand digiwand merged commit 869d7a2 into develop Jan 28, 2022
@digiwand digiwand deleted the revert-13281-fix/network-dropdown-list-zoom branch January 28, 2022 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
@digiwand digiwand linked an issue Feb 1, 2022 that may be closed by this pull request
Can't open settings if browser zoom level > 100% #10168
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanml ryanml ryanml approved these changes

@brad-decker brad-decker brad-decker approved these changes

@PeterYinusa PeterYinusa Awaiting requested review from PeterYinusa PeterYinusa is a code owner automatically assigned from MetaMask/extension-devs

@Gtonizuka Gtonizuka Awaiting requested review from Gtonizuka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't open settings if browser zoom level > 100%
4 participants
@digiwand @metamaskbot @brad-decker @ryanml