Adding metrics events for EIP-1559 V2 flow #13329

jpuri · 2022-01-17T13:08:14Z

Adding metrics events for EIP-1559 V2

github-actions · 2022-01-17T13:08:28Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

mcmire

Left some comments!

...onents/app/advanced-gas-fee-popover/advanced-gas-fee-gas-limit/advanced-gas-fee-gas-limit.js

...mponents/app/advanced-gas-fee-popover/advanced-gas-fee-defaults/advanced-gas-fee-defaults.js

ui/components/app/advanced-gas-fee-popover/advanced-gas-fee-save/advanced-gas-fee-save.js

ui/hooks/gasFeeInput/useTransactionMetrics.js

brad-decker

The event signaturess in this PR are the old metrics format, not the new...furthermore we need the fragment system in place to report the metrics in the way that product wants to use then..hold until event fragments for transactions are available

metamaskbot · 2022-01-19T14:52:28Z

Builds ready [b837ef1]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1190 ± 38 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	1201	354	424	204
		domContentLoaded	1079	1398	1189	79	38
		load	1079	1398	1190	79	38
		domInteractive	1079	1398	1189	79	38

highlights:

storybook

brad-decker

Added some additional direction. Feel free to push back on these -- this is just the design implementation I had envisioned when doing the proceeding work.

shared/constants/transaction.js

app/scripts/controllers/transactions/index.js

app/scripts/metamask-controller.js

ui/hooks/useTransactionEventFragment.js

… EIP_1559_V2_capturing_gas_defaults

Co-authored-by: Brad Decker <git@braddecker.dev>

metamaskbot · 2022-01-28T13:42:20Z

Builds ready [2bbcd62]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1233 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	1349	500	449	215
		domContentLoaded	1030	1770	1233	217	104
		load	1030	1770	1233	217	104
		domInteractive	1030	1770	1233	217	104

highlights:

storybook

metamaskbot · 2022-01-31T18:26:28Z

Builds ready [e8d554a]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1336 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	1348	370	402	193
		domContentLoaded	1062	1737	1333	204	98
		load	1062	1737	1336	203	98
		domInteractive	1062	1737	1333	204	98

highlights:

storybook

mcmire

This all looks good, just some typos I noticed.

mcmire · 2022-01-31T18:33:52Z

ui/components/app/advanced-gas-fee-popover/advanced-gas-fee-save/advanced-gas-fee-save.js

@@ -26,6 +28,11 @@ const AdvancedGasFeeSaveButton = () => {
      maxPriorityFeePerGas: decGWEIToHexWEI(maxPriorityFeePerGas),
      gasLimit,
    });
+    updateTransactionEventFragment({
+      properties: {
+        gas_edit_type: 'advance',


advanced?

my bad, Just fixed

mcmire · 2022-01-31T18:34:02Z

ui/components/app/edit-gas-fee-button/edit-gas-fee-button.js

+    openModal('editGasFee');
+  };
+
+  const openAdvanceGasFeeModal = () => {


Advance -> Advanced

mcmire · 2022-01-31T18:34:08Z

ui/components/app/edit-gas-fee-button/edit-gas-fee-button.js

+
+  const openAdvanceGasFeeModal = () => {
+    updateTransactionEventFragment({
+      gas_edit_attempted: 'advance',


advance -> advanced

metamaskbot · 2022-02-01T00:56:35Z

Builds ready [bf06141]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1111 ± 27 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	1191	364	438	210
		domContentLoaded	1029	1253	1110	57	27
		load	1029	1258	1111	57	27
		domInteractive	1029	1253	1110	57	27

highlights:

storybook

adonesky1

LGTM!

jpuri requested review from mcmire and brad-decker January 18, 2022 12:00

jpuri added the EIP-1559-V2 label Jan 18, 2022

jpuri marked this pull request as ready for review January 18, 2022 12:02

jpuri requested a review from a team as a code owner January 18, 2022 12:02

mcmire reviewed Jan 18, 2022

View reviewed changes

jpuri requested a review from mcmire January 19, 2022 10:26

brad-decker suggested changes Jan 19, 2022

View reviewed changes

jpuri added 2 commits January 24, 2022 06:37

Capturing default gas estimates in txMeta and passing it to metrics

921e33f

Adding flag for V2 transactions in metrics

ea70667

jpuri changed the base branch from develop to EIP_1559_V2_capturing_gas_defaults January 24, 2022 01:25

jpuri force-pushed the EIP-1559_v2_metrics branch 3 times, most recently from 954dd8e to 0116132 Compare January 24, 2022 03:24

jpuri marked this pull request as draft January 24, 2022 03:25

brad-decker suggested changes Jan 24, 2022

View reviewed changes

jpuri added 10 commits January 24, 2022 23:00

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

82468bc

… EIP_1559_V2_capturing_gas_defaults

Improvements

3986a1b

Improvements

d075dac

Improvements

857065b

Improvements

bd89570

Improvements

dc13c98

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

262ba46

… EIP_1559_V2_capturing_gas_defaults

fix

4e2918e

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

4cd7ae1

… EIP_1559_V2_capturing_gas_defaults

fix build

f405942

jpuri and others added 13 commits January 28, 2022 18:34

fixes

28d6a71

fix

f73e96b

Update app/scripts/controllers/transactions/index.js

f1fbd45

Co-authored-by: Brad Decker <git@braddecker.dev>

Revert changes

fdbaeb4

Revert changes

6e29d04

fixes

0fe3280

fix

547689f

fix

dfc5d46

fix

664e68a

fix

e326ca4

fix

05e5c15

fixes

6196d5a

fix build

2bbcd62

jpuri force-pushed the EIP-1559_v2_metrics branch from 5c1a43d to 2bbcd62 Compare January 28, 2022 13:05

Base automatically changed from EIP_1559_V2_capturing_gas_defaults to develop January 31, 2022 17:27

jpuri added 2 commits January 31, 2022 23:01

merge

0fa7ae5

fix build

e8d554a

mcmire reviewed Jan 31, 2022

View reviewed changes

fix

86ef58c

jpuri requested a review from mcmire January 31, 2022 18:53

fix build

bf06141

brad-decker approved these changes Feb 1, 2022

View reviewed changes

darkwing approved these changes Feb 1, 2022

View reviewed changes

adonesky1 approved these changes Feb 1, 2022

View reviewed changes

jpuri merged commit cc1861a into develop Feb 1, 2022

jpuri deleted the EIP-1559_v2_metrics branch February 1, 2022 17:53

github-actions bot locked and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding metrics events for EIP-1559 V2 flow #13329

Adding metrics events for EIP-1559 V2 flow #13329

jpuri commented Jan 17, 2022 •

edited

Loading

github-actions bot commented Jan 17, 2022

mcmire left a comment

brad-decker left a comment

metamaskbot commented Jan 19, 2022

brad-decker left a comment

metamaskbot commented Jan 28, 2022

metamaskbot commented Jan 31, 2022

mcmire left a comment

mcmire Jan 31, 2022

jpuri Jan 31, 2022 •

edited

Loading

mcmire Jan 31, 2022

jpuri Jan 31, 2022

mcmire Jan 31, 2022

jpuri Jan 31, 2022

metamaskbot commented Feb 1, 2022

adonesky1 left a comment

Adding metrics events for EIP-1559 V2 flow #13329

Adding metrics events for EIP-1559 V2 flow #13329

Conversation

jpuri commented Jan 17, 2022 • edited Loading

github-actions bot commented Jan 17, 2022

mcmire left a comment

Choose a reason for hiding this comment

brad-decker left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 19, 2022

highlights:

brad-decker left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 28, 2022

highlights:

metamaskbot commented Jan 31, 2022

highlights:

mcmire left a comment

Choose a reason for hiding this comment

mcmire Jan 31, 2022

Choose a reason for hiding this comment

jpuri Jan 31, 2022 • edited Loading

Choose a reason for hiding this comment

mcmire Jan 31, 2022

Choose a reason for hiding this comment

jpuri Jan 31, 2022

Choose a reason for hiding this comment

mcmire Jan 31, 2022

Choose a reason for hiding this comment

jpuri Jan 31, 2022

Choose a reason for hiding this comment

metamaskbot commented Feb 1, 2022

highlights:

adonesky1 left a comment

Choose a reason for hiding this comment

jpuri commented Jan 17, 2022 •

edited

Loading

jpuri Jan 31, 2022 •

edited

Loading