Skip to content

Conversation

@adonesky1
Copy link
Contributor

Fixes: #11317

Explanation: While reviewing @brad-decker send slice refactor PR I found invalid logic around editing a transaction in the send flow where the recipient address and amount were switched. Upon further digging I realized this wasn't causing a visible issue because the (back to) edit option that is available for ETH transactions is not available for token transactions (where this logic would be used). This PR adds back the edit navigation button for the send-token flow and fixes the faulty logic.

Manual testing steps:

  • Start to send a token (on any network, and token that is not its native asset)
  • Once at the confirm screen look for the edit button in the top left corner and click it
  • Edit the transaction and click forward again to confirm.
  • Send the transaction and verify that the transaction sent the correct amount to the correct address

@adonesky1 adonesky1 requested a review from a team as a code owner June 17, 2021 15:09
@adonesky1 adonesky1 requested review from brad-decker and removed request for a team June 17, 2021 15:09
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 force-pushed the add-back-edit-send-token branch 2 times, most recently from 52d82ec to 3ec9d68 Compare June 17, 2021 16:20
@adonesky1 adonesky1 force-pushed the add-back-edit-send-token branch from 1a75bfa to ceaa0be Compare June 17, 2021 19:36
@adonesky1 adonesky1 force-pushed the add-back-edit-send-token branch 3 times, most recently from 7001442 to fafc37d Compare June 18, 2021 15:25
state.draftTransaction.id = action.payload.id;
state.draftTransaction.txParams.from = action.payload.from;
slice.caseReducers.updateDraftTransaction(state);
if(state.asset.type === ASSET_TYPES.NATIVE){
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brad-decker can we take a look at this PR together sometime today? I've spent too much time trying to figure out whats going wrong. The navigate back to edit flow is behaving inconsistently for me

@adonesky1 adonesky1 requested a review from kumavis as a June 18, 2021 17:00
Base automatically changed from fix-qa-issues to improve-send-slice June 18, 2021 18:01
@adonesky1 adonesky1 force-pushed the add-back-edit-send-token branch from fafc37d to ee5d021 Compare June 18, 2021 22:07
@adonesky1 adonesky1 force-pushed the add-back-edit-send-token branch 2 times, most recently from 2803d5c to 8120baa Compare June 23, 2021 17:49
@adonesky1
Copy link
Contributor Author

@brad-decker with the fix you added for the gasLoading issue this PR appears to be working as I expect it to. Take a look when you have chance?

@metamaskbot
Copy link
Collaborator

Builds ready [8120baa]
Page Load Metrics (627 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4510065126
domContentLoaded4137576257235
load4157586277234
domInteractive4137576257234

Base automatically changed from improve-send-slice to develop June 23, 2021 21:35
@adonesky1 adonesky1 force-pushed the add-back-edit-send-token branch from 8120baa to d302637 Compare June 23, 2021 21:38
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 works like a charm!

@metamaskbot
Copy link
Collaborator

Builds ready [d302637]
Page Load Metrics (546 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43705894
domContentLoaded3796535448541
load3816535468541
domInteractive3796525448541

@adonesky1 adonesky1 requested a review from ryanml June 23, 2021 22:19
@adonesky1 adonesky1 merged commit a6e16f4 into develop Jun 23, 2021
@adonesky1 adonesky1 deleted the add-back-edit-send-token branch June 23, 2021 23:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing edit button for token send flow

5 participants