-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Adding edit navigation button flow back to send token flow #11335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ff3f046 to
e36b138
Compare
52d82ec to
3ec9d68
Compare
e36b138 to
8722722
Compare
1a75bfa to
ceaa0be
Compare
8722722 to
5065ca3
Compare
7001442 to
fafc37d
Compare
ui/ducks/send/send.js
Outdated
| state.draftTransaction.id = action.payload.id; | ||
| state.draftTransaction.txParams.from = action.payload.from; | ||
| slice.caseReducers.updateDraftTransaction(state); | ||
| if(state.asset.type === ASSET_TYPES.NATIVE){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brad-decker can we take a look at this PR together sometime today? I've spent too much time trying to figure out whats going wrong. The navigate back to edit flow is behaving inconsistently for me
fe6d9da to
1df28f2
Compare
1df28f2 to
844606b
Compare
fafc37d to
ee5d021
Compare
581597d to
849ca6a
Compare
2803d5c to
8120baa
Compare
|
@brad-decker with the fix you added for the gasLoading issue this PR appears to be working as I expect it to. Take a look when you have chance? |
Builds ready [8120baa]
Page Load Metrics (627 ± 34 ms)
|
8120baa to
d302637
Compare
brad-decker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 works like a charm!
Builds ready [d302637]
Page Load Metrics (546 ± 41 ms)
|
Fixes: #11317
Explanation: While reviewing @brad-decker send slice refactor PR I found invalid logic around editing a transaction in the send flow where the recipient address and amount were switched. Upon further digging I realized this wasn't causing a visible issue because the (back to) edit option that is available for ETH transactions is not available for token transactions (where this logic would be used). This PR adds back the edit navigation button for the send-token flow and fixes the faulty logic.
Manual testing steps: