Skip to content

Refactoring from-import-ui.spec.js to use fixtures #10907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NiranjanaBinoy merged 4 commits into from
Apr 22, 2021
Merged

Refactoring from-import-ui.spec.js to use fixtures #10907

NiranjanaBinoy merged 4 commits into from
Apr 22, 2021

Conversation

@NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Apr 20, 2021

Fixes: #10906

Explanation:

  • Moved the file to test/e2e/tests
  • Updated from-import-ui.spec.js to use fixtures.
  • Updated run-all.sh to use the new test file.
  • Deleted the old from-import-ui.spec.js file

@NiranjanaBinoy NiranjanaBinoy self-assigned this Apr 20, 2021
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner April 20, 2021 20:45
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NiranjanaBinoy NiranjanaBinoy changed the title Refactoring permissions.spec.js to use fixtures Refactoring from-import-ui.spec.js to use fixtures Apr 20, 2021
@metamaskbot
Copy link
Collaborator

metamaskbot commented Apr 21, 2021

Builds ready [6ff6ff3]
Page Load Metrics (702 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint498765105
domContentLoaded45783570110450
load45883670210450
domInteractive45783470110450

brad-decker
brad-decker approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NiranjanaBinoy NiranjanaBinoy merged commit c254e14 into develop Apr 22, 2021
@NiranjanaBinoy NiranjanaBinoy deleted the e2e-fixtures-import-ui branch April 22, 2021 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor from-import-ui.spec.js to follow pattern in metamask-extension/test/e2e/tests

4 participants

@NiranjanaBinoy @metamaskbot @brad-decker