Fix crash when adding new changelog release header #10870
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `auto-changelog.js` script crashes when trying to add a new release header. This bug was introduced in #10847. The cause was a simple misnamed parameter.
ryanml
approved these changes
Apr 9, 2021
Collaborator
Builds ready [15cfdc2]
Page Load Metrics (529 ± 46 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
auto-changelog.jsscript crashes when trying to add a new release header. This bug was introduced in #10847. The cause was a simple misnamed parameter.Manual testing steps:
versioninapp/manifest/_base.json, to simulate an RC-like environmentyarn update-changelog --rcPreviously this is where it would crash. On this branch, it should successfully add the new release header and update the changelog.