Refactoring send-edit.spec.js to use fixtures #10792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [f8c6543]
Page Load Metrics (568 ± 57 ms)
|
Collaborator
Builds ready [35b57d3]
Page Load Metrics (516 ± 50 ms)
|
Collaborator
Builds ready [f17bbde]
Page Load Metrics (556 ± 37 ms)
|
DONALDSULLENDER
previously approved these changes
Apr 1, 2021
Gudahtt
previously approved these changes
Apr 2, 2021
Member
Gudahtt
left a comment
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM!
This test seems a bit on the long side, but at least it's much shorter than before. Maybe we can split this up more later? Or consider re-introducing it blocks within a withFixtures block. But that can wait for another time.
| await driver.delay(regularDelayMs); | ||
| }); | ||
|
|
||
| it('has correct updated value on the confirm screen the transaction', async function () { |
Member
There was a problem hiding this comment.
Nit: It would be nice to at least preserve these descriptions as comments, to make these tests easier to understand.
NiranjanaBinoy
dismissed stale reviews from ghost
, Gudahtt, and DONALDSULLENDER
via
165beab
Collaborator
Builds ready [165beab]
Page Load Metrics (537 ± 45 ms)
|
Gudahtt
approved these changes
Apr 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10772
Explanation:
run-all.shto use the new test file.