[POM] Deprecation old onboarding functions to use new functions defined in Page Object Models #28226
Assignees
Labels
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-extension-platform
Comments
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 6, 2024
…e Object Models (#28202) ## **Description** - Refactor e2e tests to use onboarding flows defined in Page Object Models, as the new onboarding functions are more stable, and have removed unnecessary delays - Deprecate old onboarding functions - Correct the logic in test `test/e2e/tests/notifications/account-syncing/onboarding-with-opt-out.spec.ts` to make it more clear, we only need to toggle the basic functionality off during onboarding, it will also toggle off sync account option. - Removed ganache server in e2e tests when the ganache is not necessary [](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1) ## **Related issues** Fixes: #28226 ## **Manual testing steps** Check code readability, make sure tests pass. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Danica Shen <zhaodanica@gmail.com>
](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1){kind=link}
metamaskbot
added
the
release-12.8.0
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Refactor e2e tests to use onboarding flows defined in Page Object Models, as the new onboarding functions are more stable, and have removed unnecessary delays
Deprecate old onboarding functions
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: