Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ppom failing on RC v12.5 #27909

Closed
bschorchit opened this issue Oct 16, 2024 · 3 comments · Fixed by #27939
Closed

[Bug]: ppom failing on RC v12.5 #27909

bschorchit opened this issue Oct 16, 2024 · 3 comments · Fixed by #27939
Assignees
Labels
regression-RC-12.5.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.7.0 Issue or pull request that will be included in release 12.7.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team team-wallet-framework type-bug

Comments

@bschorchit
Copy link

Describe the bug

For the same transaction, ppom is successful on v12.4.0 while it fails on RC v12.5.0. On both releases, ppom version is the same and the node provider being used should be the same too (networks were added from the network menu within the wallet).

Console logs on v12.5 on BNB:

{
  "code": -32603,
  "message": "Internal JSON-RPC error.",
  "data": {
    "code": -32002,
    "message": "the resource debug_traceCall is not available.",
    "cause": null
  },

Console logs on v12.5 on Base

sentry-install.js:1 {
  "code": -32603,
  "message": "Non-200 status code: '403'",
  "data": {
    "jsonrpc": "2.0",
    "error": {
      "code": -32601,
      "message": "rpc method is unsupported"
    },
    "id": 6378648550496817,
    "cause": null
    },

Expected behavior

ppom works as expected.

Screenshots/Recordings

v12.4.0:
image

v12.5.0:
image

Steps to reproduce

  1. Add BNB and Base networks from the network menu
  2. Go to test dapp
  3. Trigger Malicious erc20 approval (BUSD) on BNB or Base
  4. See the error message being show

Error messages or log output

No response

Detection stage

During release testing

Version

12.5

Build type

None

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@bschorchit bschorchit added type-bug Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-assets team-confirmations Push issues to confirmations team regression-RC-12.5.0 release-blocker This bug is blocking the next release labels Oct 16, 2024
@metamaskbot metamaskbot added regression-RC-12.5 Regression bug that was found in release candidate (RC) for release 12.5 and removed regression-RC-12.5.0 labels Oct 16, 2024
@bschorchit bschorchit added regression-RC-12.5.0 team-wallet-framework and removed team-assets regression-RC-12.5 Regression bug that was found in release candidate (RC) for release 12.5 labels Oct 16, 2024
@cryptodev-2s cryptodev-2s mentioned this issue Oct 17, 2024
7 tasks
@Unik0rnMaggie
Copy link
Contributor

Unik0rnMaggie commented Oct 17, 2024

Reproduced on Version-v12.5.0 local build, MacOS, browsers Chrome & Firefox.

Networks: Ethereum Mainnet, Sepolia, BNB, Base, Linea, Avalanche, Arbitrum

PPOM failing for:

  • Malicious ERC20 transfer (USDC)
  • Malicious ERC20 Approval (BUSD)
  • Malicious Set Approval for All
  • Malicious ERC 20 Approval with Odd Hex Data

Console log errors - Chrome:

code": -32603,
  "message": "Internal JSON-RPC error.",
  "data": {
    "code": -32601,
    "message": "The method debug_traceCall does not exist/is not available",
    "cause": null


   

    "code": -32603,
  "message": "Non-200 status code: '403'",
  "data": {
    "jsonrpc": "2.0",
    "error": {
      "code": -32601,
      "message": "rpc method is unsupported"
    },
    "id": 5903517567864522,
    "cause": null

Console log errors - Firefox:

Error validating JSON RPC using PPOM: Error: simulation: JS: JsValue(Error: Non-200 status code: '403'
Base, Avalanche

Error validating JSON RPC using PPOM: Error: simulation: JS: JsValue(Error: Internal JSON-RPC error.
Arbitrum, BNB



Error: simulation: JS: JsValue(Error: The method debug_traceCall does not exist/is not available
Linea, Ethereum Mainnet

Screen.Recording.2024-10-17.at.12.39.55.mov

@Unik0rnMaggie
Copy link
Contributor

Firefox PPOM errors

Base_Firefox.mov
BNB_Firefox.mov
Sepolia_Firefox.mov

github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps `@metamask/ppom-validator ` from `0.34.0` to `0.35.1`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27939?quickstart=1)

## **Related issues**

Fixes: #27909

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 17, 2024
danjm pushed a commit that referenced this issue Oct 17, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps `@metamask/ppom-validator ` from `0.34.0` to `0.35.1`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27939?quickstart=1)

Fixes: #27909

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
cryptodev-2s added a commit that referenced this issue Oct 17, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps `@metamask/ppom-validator ` from `0.34.0` to `0.35.1`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27939?quickstart=1)

Fixes: #27909

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
cryptodev-2s added a commit that referenced this issue Oct 17, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps `@metamask/ppom-validator ` from `0.34.0` to `0.35.1`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27939?quickstart=1)

Fixes: #27909

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Oct 18, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on issue. Adding release label release-12.5.0 on issue, as issue is linked to PR #27939 which has this release label.

cryptodev-2s added a commit that referenced this issue Oct 18, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps `@metamask/ppom-validator ` from `0.34.0` to `0.35.1`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27939?quickstart=1)

Fixes: #27909

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-12.5.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.7.0 Issue or pull request that will be included in release 12.7.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team team-wallet-framework type-bug
Projects
Archived in project
Status: Fixed
Development

Successfully merging a pull request may close this issue.

4 participants