Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When a transaction fails the subsequent transaction created on another network adopts a nonce from the previosly failed transaction #27657

Closed
sleepytanya opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
regression-RC-12.4.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

When a transaction fails the subsequent transaction created on another network adopts a nonce from the previosly failed transaction

Expected behavior

Transactions created with the correct nonce value

Screenshots/Recordings

371948510-4f994638-fd22-466b-abd9-3725eaab11e5.mov

Steps to reproduce

  1. Connect to Arbitrum
  2. Submit transaction with the high nonce
  3. Observe it fails with Internal JSON RPC error
  4. Switch to BNB Chain
  5. Start a transaction
  6. Transaction is created with the same nonce as failed transaction on Arbitrum

Error messages or log output

No response

Detection stage

During release testing

Version

12.4.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@benjisclowder benjisclowder added the Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. label Oct 8, 2024
danjm pushed a commit that referenced this issue Oct 8, 2024
…ks between transactions (#27634)

## **Description**

Nonce in state should be reset correctly when switching between
different networks.
The issue is already fixed in develop by PR:
#27297

## **Related issues**

Fixes: #27657

## **Manual testing steps**

1. Connect to Arbitrum
2. Submit transaction with the high nonce
3. Observe it fails with Internal JSON RPC error
4. Switch to BNB Chain
5. Start a transaction
6. Transaction is created with correct nonce

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@bschorchit
Copy link

Closing as fixed by: #27634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-12.4.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team type-bug
Projects
Archived in project
Status: Fixed
Development

No branches or pull requests

4 participants