## **Description** In this PR we fix some flaky tests. The main issue seems to be that the validation takes some seconds until it ends, and now we are displaying the intermediate state with a loading spinner. For fixing it, we add the `await driver.waitForElementNotPresent('.loading-indicator');` to wait for the Blockaid loading spinner to disappear, and then search for the Blockaid warning ## **Related issues** Fixes: - #22908 ## **Manual testing steps** 1. Check circle ci runs (ignore the deps-audit failing job, as it's unrelated) https://app.circleci.com/pipelines/github/MetaMask/metamask-extension?branch=test-fix-flaky-ppom-spinner - 🟢 Run 1 - 🟢 Run 2 - 🟢 Run 3 (phishing detection test failed here, but it's not related to this PR) - 🟢 Run 4 ## **Screenshots/Recordings** ![Screenshot from 2024-02-13 12-14-39](https://github.com/MetaMask/metamask-extension/assets/54408225/cbc1d63f-61be-4987-baf8-d6a6a6dc74fd) ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Howard Braham <howrad@gmail.com>

Fix "PPOM Blockaid Alert - Multiple Networks Support @no-..." flaky tests #22908

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions