Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sentry] Error: Unable to determine contract standard #17287

Closed
sentry-io bot opened this issue Jan 19, 2023 · 6 comments · Fixed by #18300 or #28030
Closed

[Sentry] Error: Unable to determine contract standard #17287

sentry-io bot opened this issue Jan 19, 2023 · 6 comments · Fixed by #18300 or #28030
Assignees
@Gudahtt
Labels
area-Sentry error reporting to sentry regression-prod-12.5.1 Regression bug that was found in production in release 12.5.1 release-12.8.0 Issue or pull request that will be included in release 12.8.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets team-extension-platform type-bug

Comments

@sentry-io
Copy link

sentry-io bot commented Jan 19, 2023

Sentry Issue: METAMASK-MK2Z

Error: Unable to determine contract standard
  at Generator.throw (<anonymous>)
@amerkadicE amerkadicE self-assigned this Jan 27, 2023
@danjm danjm added the PS-team PS MM extension team issues label Feb 6, 2023
@bschorchit
Copy link

Could be related to #18135

@amerkadicE amerkadicE mentioned this issue Mar 23, 2023
Merged
8 tasks
@Gudahtt
Copy link
Member

Gudahtt commented May 24, 2024

This apparently was not fixed by #18300, it is still happening in production

@Gudahtt Gudahtt reopened this May 24, 2024
@Gudahtt Gudahtt assigned Gudahtt and unassigned amerkadicE May 24, 2024
@Gudahtt Gudahtt added team-extension-platform and removed PS-team PS MM extension team issues labels May 24, 2024
@Gudahtt
Copy link
Member

Gudahtt commented May 24, 2024

Actually, on closer inspection, it looks like this was fixed but it recurred again for a separate reason.

@seaona
Copy link
Contributor

seaona commented Sep 13, 2024

This issue is still present and it seems is the cause of blocking me sending ETH to a contract.

Repro:

  1. deploy this contract
  2. try to send ETH to the deployed contract
  3. see UI console
contract Destruction {

    function destruct(address myContract) public {
        selfdestruct(payable(myContract));
    }

    function getMoney() public{
        msg.sender.transfer(address(this).balance);
    }
}

Might be related to this #21867

unable-contract-standard.mp4

@sentry-io Sentry.io
Copy link
Author

sentry-io bot commented Oct 21, 2024

Sentry Issue: METAMASK-XB6R

@gauthierpetetin gauthierpetetin added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets labels Oct 21, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Oct 21, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Oct 21, 2024
@sahar-fehri sahar-fehri mentioned this issue Oct 22, 2024
Merged
7 tasks
@sentry-io Sentry.io
Copy link
Author

sentry-io bot commented Nov 4, 2024

Sentry Issue: METAMASK-XCJ8

github-merge-queue bot pushed a commit that referenced this issue Nov 4, 2024
@sahar-fehri @darkwing
fix: ignore error when getTokenStandardAndDetails fails (#28030)
aaee4e7 
## **Description**

Fixes Sentry issue when we are not able to determine token contract
standard.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28030?quickstart=1)

## **Related issues**

Fixes: #17287

## **Manual testing steps**

(I was not able to repro with my NFTs but to simulate, we can go to the
core fct `getTokenStandardAndDetails` and add
`throw new Error('Unable to determine contract standard');` at the start
of the fct;

1. Go NFT page
2. Click on any NFT
3. Click Send
4. You should be able to send the NFT

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/2ef39b0e-106a-48a2-a150-82176adaf14c

### **After**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/f0714310-410f-4f51-b7e2-6f0bc4011027




## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Nov 4, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024
@metamaskbot metamaskbot changed the title Error: Unable to determine contract standard [Sentry] Error: Unable to determine contract standard Nov 5, 2024
@metamaskbot metamaskbot added area-Sentry error reporting to sentry regression-prod-12.5.1 Regression bug that was found in production in release 12.5.1 labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gudahtt Gudahtt

Labels
area-Sentry error reporting to sentry regression-prod-12.5.1 Regression bug that was found in production in release 12.5.1 release-12.8.0 Issue or pull request that will be included in release 12.8.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets team-extension-platform type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
8 participants
@Gudahtt @gauthierpetetin @danjm @bschorchit @metamaskbot @seaona @amerkadicE and others