[Bug]: Metamask freezes calling approve on a specific NFT contract

[etherwaifu]

Describe the bug

This problem relates to the OpenSea wrapper for the NFT Etherwaifu. If you go to

https://wwaifus.com/

And click "Approve" (id can be any number, you don't need to own the NFT), Metamask dialog will pop up but it will do the loading animation forever. It used to work previously (perhaps bug in newest Metamask?), and it still works in Metamask iOS.

Steps to reproduce

1. Go to https://wwaifus.com/
2. Click "Approve"

(it will try to call approve(0x9357a3B394798c1575218d18910e926b275Ea07a, TOKEN_ID) on the contract 0x36697e362Ee7E9CA977b7550B3e4f955fc5BF27d )

Error messages or log output

Metamask will pop up but show loading animation forever.

Version

10.12.4

Build type

No response

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

[testermumatstudio]

same here !

[Jochy1873]

El El lun, abr. 25, 2022 a la(s) 10:00 p.m., testermumatstudio < ***@***.***> escribió:

same here ! — Reply to this email directly, view it on GitHub <#14518 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMNZJQUTOZ7ZOMLDMAPRUC3VG5L45ANCNFSM5UHCQPPA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- iPhone

[alex38160]

Hello guys !

Alex from MyNFT team here. I've found where the problem is originated. This is when metamask is calling ERC165 supportInterface on the contract. It need to include, in case of ERC721 with optional ERC721Metadata and ERC165; each of the interface.

Example of what don't work :

    function supportsInterface(bytes4 interfaceID) external pure returns(bool) {
        return (
            interfaceID == 0x80ac58cd || //ERC721
            interfaceID == 0x01ffc9a7 //ERC165
        );
    }

Example of what work :

function supportsInterface(bytes4 _interfaceID) external pure returns(bool) {
        return  _interfaceID == type(ERC721).interfaceId || _interfaceID == type(ERC721Metadata).interfaceId || _interfaceID == type(ERC165).interfaceId;        
    }

[Garito]

Even if the contract is not correctly build, metamask should deal with the problem not crash

[Garito]

Besides that, I have this supportsInterface:

function supportsInterface(bytes4 interfaceId) public view virtual override(ERC721, RoyaltyInfo) returns (bool) {
    return interfaceId == type(IRoyaltyInfo).interfaceId || super.supportsInterface(interfaceId);
  }

should be ok, isn't it?

[Garito]

This show in the wallet inspector:
Failed to load resource: the server responded with a status of 429 (Too Many Requests)
@ sentry

[alex38160]

This show in the wallet inspector: Failed to load resource: the server responded with a status of 429 (Too Many Requests) @ sentry

This one is not important/related. Just metamask company having not the right package for sentry, which is a client side log handler.

In regard of what you have posted, i'd say look around about which ERC721 standard and substandard (Metadata, Enumerable, Ownable, etc.) are used in your end contract (once all the inheritance has been done). And then make your last supportInterface function support exactly each of these one, without anything else. The interfaces code in the "type()" function should be exactly what you have in the EIPs, one for each of them.

[alex38160]

Even if the contract is not correctly build, metamask should deal with the problem not crash

And.. I totally agree with this. This is extra "nice to have" functionality blocking a "core" one (ie: calling a function on a contract; no need context ultimately).

[testermumatstudio]

not working yet :/

[alex38160]

Well, this one is working : https://github.com/Perpetual-Altruism-Ltd/myNFT-Bridge/blob/master/Codebase/Bridge_Contracts/contracts/manipulator/721/IOU.sol
Play find the differences ! :D

[kevinghim]

Might be related to #14459