Response to latest @georgewrmarshall review

MetaMask · Mar 3, 2023 · ee95fc8 · ee95fc8
1 parent abbfb03
commit ee95fc8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/ui/components/component-library/text/text.constants.js b/ui/components/component-library/text/text.constants.js
@@ -8,4 +8,4 @@ export const TEXT_DIRECTIONS = {
  * The INVISIBLE_CHARACTER is a very useful tool if you want to make sure a line of text
  * takes up vertical space even if it's empty.
  */
-export const INVISIBLE_CHARACTER = '\u200d';
+export const INVISIBLE_CHARACTER = '\u200B';
diff --git a/ui/pages/create-account/import-account/bottom-buttons.js b/ui/pages/create-account/import-account/bottom-buttons.js
@@ -24,7 +24,7 @@ export default function BottomButtons({
   const dispatch = useDispatch();
 
   return (
-    <Box display={DISPLAY.FLEX}>
+    <Box display={DISPLAY.FLEX} gap={4}>
       <ButtonSecondary
         onClick={() => {
           dispatch(actions.hideWarning());

diff --git a/ui/pages/create-account/import-account/import-account.js b/ui/pages/create-account/import-account/import-account.js
@@ -119,7 +119,7 @@ export default function NewAccountImportForm() {
     <>
       <Box
         padding={4}
-        style={{ borderWidth: '0px 0px 1px 0px' }} // There is no way to do just a bottom border in the Design System
+        className="bottom-border-1px" // There is no way to do just a bottom border in the Design System
         borderColor={BorderColor.borderDefault}
       >
         <Text variant={TextVariant.headingLg}>{t('importAccount')}</Text>

diff --git a/ui/pages/create-account/index.scss b/ui/pages/create-account/index.scss
@@ -16,6 +16,10 @@
   @include screen-sm-min {
     position: absolute;
   }
+
+  .bottom-border-1px {
+    border-width: 0px 0px 1px 0px;
+  }
 }