update unit test mocks to not modify child state by reference

MetaMask · Sep 18, 2024 · e1db1c3 · e1db1c3
1 parent d75e942
commit e1db1c3
Showing 1 changed file with 48 additions and 15 deletions.
diff --git a/app/scripts/migrations/127.test.ts b/app/scripts/migrations/127.test.ts
@@ -51,9 +51,12 @@ describe(`migration #${version}`, () => {
       },
     };
 
-    const expectedState = defaultPostMigrationState();
-    const expectedNetwork =
-      expectedState.networkConfigurationsByChainId[customNetwork.chainId];
+    const defaultStateToExpect = defaultPostMigrationState();
+    const expectedNetwork = {
+      ...defaultStateToExpect.networkConfigurationsByChainId[
+        customNetwork.chainId
+      ],
+    };
 
     // The custom network's rpc url should be added to the existing network
     expectedNetwork.rpcEndpoints.push({
@@ -68,6 +71,14 @@ describe(`migration #${version}`, () => {
       customNetwork.rpcPrefs.blockExplorerUrl,
     );
 
+    const expectedState = {
+      ...defaultStateToExpect,
+      networkConfigurationsByChainId: {
+        ...defaultStateToExpect.networkConfigurationsByChainId,
+        [customNetwork.chainId]: expectedNetwork,
+      },
+    };
+
     const newState = await migrate(oldState);
     expect(newState.data.NetworkController).toStrictEqual(expectedState);
   });
@@ -144,12 +155,14 @@ describe(`migration #${version}`, () => {
       },
     };
 
-    const expectedState = defaultPostMigrationState();
-    const expectedNetwork =
-      expectedState.networkConfigurationsByChainId[customNetwork.chainId];
+    const defaultStateToExpect = defaultPostMigrationState();
+    const expectedNetwork = {
+      ...defaultStateToExpect.networkConfigurationsByChainId[
+        customNetwork.chainId
+      ],
+    };
 
-    // The custom network should remain selected, and become the default RPC url
-    expectedState.selectedNetworkClientId = customNetwork.id;
+    // The custom network should become the default RPC url
     expectedNetwork.defaultRpcEndpointIndex =
       expectedNetwork.rpcEndpoints.push({
         networkClientId: customNetwork.id,
@@ -165,6 +178,16 @@ describe(`migration #${version}`, () => {
         customNetwork.rpcPrefs.blockExplorerUrl,
       ) - 1;
 
+    const expectedState = {
+      ...defaultStateToExpect,
+      // The custom network should remain selected
+      selectedNetworkClientId: customNetwork.id,
+      networkConfigurationsByChainId: {
+        ...defaultStateToExpect.networkConfigurationsByChainId,
+        [customNetwork.chainId]: expectedNetwork,
+      },
+    };
+
     const newState = await migrate(oldState);
     expect(newState.data.NetworkController).toStrictEqual(expectedState);
   });
@@ -207,13 +230,12 @@ describe(`migration #${version}`, () => {
       },
     };
 
-    // Selected network shouldn't change
-    const expectedState = defaultPostMigrationState();
-    expectedState.selectedNetworkClientId =
-      oldState.data.NetworkController.selectedNetworkClientId;
-
-    const expectedNetwork =
-      expectedState.networkConfigurationsByChainId[customNetwork.chainId];
+    const defaultStateToExpect = defaultPostMigrationState();
+    const expectedNetwork = {
+      ...defaultStateToExpect.networkConfigurationsByChainId[
+        customNetwork.chainId
+      ],
+    };
 
     // The custom network's rpc url should be added to the
     // existing network, and become the default RPC url
@@ -232,6 +254,17 @@ describe(`migration #${version}`, () => {
         customNetwork.rpcPrefs.blockExplorerUrl,
       ) - 1;
 
+    const expectedState = {
+      ...defaultStateToExpect,
+      // Selected network shouldn't change
+      selectedNetworkClientId:
+        oldState.data.NetworkController.selectedNetworkClientId,
+      networkConfigurationsByChainId: {
+        ...defaultStateToExpect.networkConfigurationsByChainId,
+        [customNetwork.chainId]: expectedNetwork,
+      },
+    };
+
     const newState = await migrate(oldState);
     expect(newState.data.NetworkController).toStrictEqual(expectedState);
   });