Skip to content

Commit

Permalink
fix: no connected state for permissions page (#27660)
Browse files Browse the repository at this point in the history
This PR is to add padding to the permissions page when no site or snap
is connected

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to All permissions page
2. Disconnect all sites and snaps
3. Check the copy is center aligned when not connected

## **Screenshots/Recordings**


### **Before**
![Screenshot 2024-10-07 at 2 02
28 PM](https://github.com/user-attachments/assets/b3a46aba-a5f0-4ad3-a1dc-4e59d6d70c88)


### **After**

![Screenshot 2024-10-07 at 2 02
10 PM](https://github.com/user-attachments/assets/07ccf534-3c8e-4ee4-904a-77c6ed0a606a)

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
NidhiKJha authored Oct 14, 2024
1 parent bf31876 commit d9d6fab
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export const PermissionsPage = () => {
justifyContent={JustifyContent.center}
height={BlockSize.Full}
gap={2}
padding={4}
>
<Text
variant={TextVariant.bodyMdMedium}
Expand Down

0 comments on commit d9d6fab

Please sign in to comment.