Fixes #17719

MetaMask · Feb 21, 2023 · 87a1638 · 87a1638
1 parent 0223757
commit 87a1638
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/app/scripts/account-import-strategies/index.js b/app/scripts/account-import-strategies/index.js
@@ -1,5 +1,10 @@
 import { isValidMnemonic } from '@ethersproject/hdnode';
-import { bufferToHex, isValidPrivate, toBuffer } from 'ethereumjs-util';
+import {
+  bufferToHex,
+  getBinarySize,
+  isValidPrivate,
+  toBuffer,
+} from 'ethereumjs-util';
 import Wallet from 'ethereumjs-wallet';
 import importers from 'ethereumjs-wallet/thirdparty';
 import log from 'loglevel';
@@ -35,7 +40,10 @@ const accountImporter = {
       }
 
       try {
-        if (!isValidPrivate(buffer)) {
+        if (
+          !isValidPrivate(buffer) ||
+          getBinarySize(trimmedPrivateKey) !== 64 // isValidPrivate() will let a key of 63 hex digits through without complaining
+        ) {
           throw new Error(`t('importAccountErrorNotAValidPrivateKey')`);
         }
       } catch (e) {