Skip to content

Commit

Permalink
trying to comment out waitForElementNotPresent to check if the old e2…
Browse files Browse the repository at this point in the history
…e failures could have been fixed with update branch
  • Loading branch information
NiranjanaBinoy committed Feb 3, 2023
1 parent d37ae19 commit 7d470ef
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions test/e2e/metamask-ui.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ describe('MetaMask', function () {
},
{ timeout: 10000 },
);
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');
await driver.clickElement('.transaction-list-item__primary-currency');
await driver.delay(regularDelayMs);

Expand Down Expand Up @@ -467,7 +467,7 @@ describe('MetaMask', function () {
text: '7.5 TST',
});

await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');
await driver.clickElement({
text: 'Activity',
tag: 'button',
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/tests/collectibles.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('Collectibles', function () {
'.transaction-list__completed-transactions .transaction-list-item:nth-of-type(1)',
{ timeout: 10000 },
);
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');

// Verify transaction
const completedTx = await driver.findElement('.list-item__title');
Expand Down Expand Up @@ -128,7 +128,7 @@ describe('Collectibles', function () {
'.transaction-list__completed-transactions .transaction-list-item:nth-of-type(1)',
{ timeout: 10000 },
);
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');

// Verify transaction
const completedTx = await driver.findElement('.list-item__title');
Expand Down Expand Up @@ -198,7 +198,7 @@ describe('Collectibles', function () {
'.transaction-list__completed-transactions .transaction-list-item:nth-of-type(1)',
{ timeout: 10000 },
);
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');

// Verify transaction
const completedTx = await driver.findElement('.list-item__title');
Expand Down Expand Up @@ -271,7 +271,7 @@ describe('Collectibles', function () {
'.transaction-list__completed-transactions .transaction-list-item:nth-of-type(1)',
{ timeout: 10000 },
);
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');

// Verify transaction
const completedTx = await driver.findElement('.list-item__title');
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/tests/custom-token-add-approve.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ describe('Create token, approve token and approve token without gas', function (
return pendingTxes.length === 1;
}, 10000);

await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');
const approveTokenTask = await driver.waitForSelector({
// Selects only the very first transaction list item immediately following the 'Pending' header
css: '.transaction-list__completed-transactions .transaction-list-item:first-child .list-item__heading',
Expand Down Expand Up @@ -473,7 +473,7 @@ describe('Create token, approve token and approve token without gas', function (
await driver.switchToWindow(extension);
await driver.clickElement({ tag: 'button', text: 'Activity' });

await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');
const pendingTxes = await driver.findElements('.transaction-list-item');
pendingTxes[0].click();
// set spending cap
Expand All @@ -488,7 +488,7 @@ describe('Create token, approve token and approve token without gas', function (

await driver.delay(500);
await driver.clickElement({ text: 'Approve', tag: 'button' });
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');

// check transaction in Activity tab
const approveTokenTask = await driver.waitForSelector({
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/tests/send-hex-address.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe('Send ETH to a 40 character hexadecimal address', function () {

// Confirm transaction
await driver.clickElement({ text: 'Confirm', tag: 'button' });
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');
await driver.clickElement('[data-testid="home__activity-tab"]');
const sendTransactionListItem = await driver.waitForSelector(
'.transaction-list__completed-transactions .transaction-list-item',
Expand Down Expand Up @@ -91,7 +91,7 @@ describe('Send ETH to a 40 character hexadecimal address', function () {

// Confirm transaction
await driver.clickElement({ text: 'Confirm', tag: 'button' });
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');
await driver.clickElement('[data-testid="home__activity-tab"]');
const sendTransactionListItem = await driver.waitForSelector(
'.transaction-list__completed-transactions .transaction-list-item',
Expand Down Expand Up @@ -186,7 +186,7 @@ describe('Send ERC20 to a 40 character hexadecimal address', function () {
text: '0 TST',
});
await driver.clickElement({ text: 'Confirm', tag: 'button' });
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');
await driver.clickElement('[data-testid="home__activity-tab"]');
await driver.waitForSelector(
'.transaction-list__completed-transactions .transaction-list-item:nth-of-type(1)',
Expand Down Expand Up @@ -271,7 +271,7 @@ describe('Send ERC20 to a 40 character hexadecimal address', function () {
text: '0 TST',
});
await driver.clickElement({ text: 'Confirm', tag: 'button' });
await driver.waitForElementNotPresent('.loading-overlay');
// await driver.waitForElementNotPresent('.loading-overlay');
await driver.clickElement('[data-testid="home__activity-tab"]');
await driver.waitForSelector(
'.transaction-list__completed-transactions .transaction-list-item:nth-of-type(1)',
Expand Down

0 comments on commit 7d470ef

Please sign in to comment.