-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Reword embedded wallets whitelist to allowlist #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yashovardhan
wants to merge
9
commits into
main
Choose a base branch
from
feat/reword-embedded-wallets-whitelist-to-allowlist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reword embedded wallets whitelist to allowlist #2640
yashovardhan
wants to merge
9
commits into
main
from
feat/reword-embedded-wallets-whitelist-to-allowlist
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
We need to configure vercel redirect for whitelist -> allowlist for the page changed |
Member
Author
|
vercel redirect added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @m4sterbunny the web3auth dashboard now says allowlist for allowed domains.
Note
Standardizes terminology from "whitelist" to "allowlist" across the Embedded Wallets documentation and examples.
dashboard/allowlist.mdxand updates all references, copy, and headings (dashboard, SDK READMEs for Android/iOS/Flutter/Unity/Unreal, RN/Unity tables) to use “allowlist”allowlistand removes oldwhitelistpages/embedded-wallets/dashboard/whitelist/to/embedded-wallets/dashboard/allowlist/registerApp.mdxWritten by Cursor Bugbot for commit 5eddcf0. This will update automatically on new commits. Configure here.