This repository was archived by the owner on Nov 9, 2023. It is now read-only.
update eslint and other packages to be aligned with core monorepo #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @metamask/eslint-config@9.0.0, eslint@7.32.0, eslint-plugin-node@11.1.0 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Gudahtt
reviewed
Sep 22, 2023
src/index.test.ts
Outdated
| import { Duplex } from 'stream'; | ||
| import { JsonRpcEngine } from '@metamask/json-rpc-engine'; | ||
| import PortStream from 'extension-port-stream'; | ||
| /* eslint import/no-nodejs-modules: ["error", {"allow": ["stream"]}] */ |
Member
There was a problem hiding this comment.
Nit: It might be better to disable this rule entirely for *.test.ts files, since using Node.js packages is OK in tests. That rule is intended to help keep the package portable across Node.js and web, which doesn't apply to tests of course.
Contributor
Author
There was a problem hiding this comment.
The changes have been pushed.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in the process of migrating the json-rpc-middleware-stream repo to the core monorepo. Before the actual migration we would like to update the packages to be aligned with core monorepo.
This PR updates the eslint and other packages to be aligned with the core monorepo and which also required changes in the code to pass the lint.
Fixes <url-issue>