Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 4, 2023

@socket-security
Copy link

socket-security bot commented Sep 4, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@socket-security
Copy link

socket-security bot commented Sep 4, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat
Copy link
Contributor Author

legobeat commented Sep 4, 2023

@SocketSecurity ignore global-prefix@1.0.2
@SocketSecurity ignore resolve-dir@1.0.1
@SocketSecurity ignore expand-tilde@2.0.2
@SocketSecurity ignore cosmiconfig@7.1.0
@SocketSecurity ignore is-windows@1.0.2
@SocketSecurity ignore homedir-polyfill@1.0.3
@SocketSecurity ignore semver-compare@1.0.0
@SocketSecurity ignore please-upgrade-node@3.2.0
@SocketSecurity ignore detect-file@1.0.0
@SocketSecurity ignore deps-regex@0.1.4
@SocketSecurity ignore source-map-js@1.0.2
@SocketSecurity ignore @types/parse-json@4.0.0
@SocketSecurity ignore parse-passwd@1.0.0
@SocketSecurity ignore multimatch@5.0.0
@SocketSecurity ignore require-package-name@2.0.1
@SocketSecurity ignore global-modules@1.0.0
@SocketSecurity ignore findup-sync@5.0.0
@SocketSecurity ignore array-differ@3.0.0
@SocketSecurity ignore readdirp@3.6.0
@SocketSecurity ignore callsite@1.0.0
@SocketSecurity ignore arrify@2.0.1
@SocketSecurity ignore depcheck@1.4.5

@legobeat legobeat marked this pull request as ready for review September 4, 2023 23:20
@legobeat legobeat requested a review from a team as a code owner September 4, 2023 23:20
@legobeat legobeat requested a review from kanthesha September 21, 2023 08:48
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

A note:
As we are about to migrate this package to core with MetaMask/core#1680 this will be removed anyway.

Still, could be useful while working on MetaMask/core#1684
cc @kanthesha

Copy link

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kanthesha
Copy link
Contributor

kanthesha commented Sep 21, 2023

Can we add a description about why we are doing the PR! We can see it's for depcheck, it'll be helpful for someone new if there's little more info on why depcheck.
Other than that, LGTM.

@legobeat legobeat merged commit 1c2c521 into MetaMask:main Sep 21, 2023
@kanthesha kanthesha mentioned this pull request Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants