-
-
Notifications
You must be signed in to change notification settings - Fork 22
lint: add lint:dependencies using depcheck #57
Conversation
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
3c96d12 to
9145eb9
Compare
9145eb9 to
9b26aef
Compare
…cjs to depcheckIgnore
mikesposito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A note:
As we are about to migrate this package to core with MetaMask/core#1680 this will be removed anyway.
Still, could be useful while working on MetaMask/core#1684
cc @kanthesha
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Can we add a description about why we are doing the PR! We can see it's for depcheck, it'll be helpful for someone new if there's little more info on why depcheck. |
Carries over dependency linting from https://github.com/MetaMask/metamask-module-template/blob/dc15354bb3086d20c5e1d80c2025b02655ab5360/package.json#L42 to check for inconsistent imports/deps.
uses: https://github.com/depcheck/depcheck/