Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

4.0.0 #29

Merged
merged 5 commits into from
Oct 5, 2022
Merged

4.0.0 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee19bef
4.0.0
invalid-email-address Oct 3, 2022
8d7d215
changelog fixes
jpuri Oct 3, 2022
de570ff
Update CHANGELOG.md
jpuri Oct 4, 2022
50cc350
fix
jpuri Oct 4, 2022
43d18a1
fix
jpuri Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [4.0.0] - 2022-10-03
### Changed
Copy link
Member

@Gudahtt Gudahtt Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing: #15

Specifically, the change in minimum supported Node.js version is notable, because it's a breaking change.

Copy link

@mcmire mcmire Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I missed this one. Might be good then to add something like:

- Add Node 12 as minimum required version [#15](https://github.com/MetaMask/json-rpc-middleware-stream/pull/15)

right before

- Retry pending requests when notification to reconnect is received ([#27](https://github.com/MetaMask/json-rpc-middleware-stream/pull/27))

?

Copy link
Member

@Gudahtt Gudahtt Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except it should be prefixed with "BREAKING:"

Copy link

@mcmire mcmire Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point.

Copy link
Member

@Gudahtt Gudahtt Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpuri could you add the "BREAKING:" prefix, so that people know which change is breaking?

Copy link
Contributor

@jpuri jpuri Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is updated

- BREAKING: Add Node 12 as minimum required version [#15](https://github.com/MetaMask/json-rpc-middleware-stream/pull/15)
- Retry pending requests when notification to reconnect is received ([#27](https://github.com/MetaMask/json-rpc-middleware-stream/pull/27))

### Security
- Add `@lavamoat/allow-scripts` to make dependency install scripts opt-in ([#25](https://github.com/MetaMask/json-rpc-middleware-stream/pull/25))

## [3.0.0] - 2020-12-08
### Added
- TypeScript typings ([#11](https://github.com/MetaMask/json-rpc-middleware-stream/pull/11))

[Unreleased]: https://github.com/MetaMask/json-rpc-middleware-stream/compare/v3.0.0...HEAD
[Unreleased]: https://github.com/MetaMask/json-rpc-middleware-stream/compare/v4.0.0...HEAD
[4.0.0]: https://github.com/MetaMask/json-rpc-middleware-stream/compare/v3.0.0...v4.0.0
[3.0.0]: https://github.com/MetaMask/json-rpc-middleware-stream/releases/tag/v3.0.0
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "json-rpc-middleware-stream",
"version": "3.0.0",
"version": "4.0.0",
"description": "A small toolset for streaming JSON-RPC data and matching requests and responses.",
"repository": {
"type": "git",
Expand Down