This repository was archived by the owner on Nov 9, 2023. It is now read-only.
fix: clean up engine listener #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iantanwx
force-pushed
the
fix/cleanup-dangling-listeners
branch
2 times, most recently
from
203c972 to
3bccffa
Compare
BelfordZ
reviewed
Jul 6, 2022
src/createEngineStream.ts
Outdated
| }); | ||
| const onNotification = (message: unknown) => stream.push(message); | ||
| engine.on('notification', onNotification); | ||
| stream.on('end', () => engine.off('notification', onNotification)); |
There was a problem hiding this comment.
should this be on('close', ... ? Doesn't the 'end' event get fired for every notification?
Author
There was a problem hiding this comment.
you're right, changed it. thanks.
iantanwx
force-pushed
the
fix/cleanup-dangling-listeners
branch
from
3bccffa to
5b4693e
Compare
mcmire
approved these changes
Oct 5, 2023
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for doing this.
|
@iantanwx ^ Oh, looks like we have some conflicts. Would you mind bringing in updates from |
Contributor
|
This library has now been migrated into the core monorepo. This PR has been locked and this repo will be archived shortly. Going forward, releases of this library will only include changes made in the core repo.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enginemay be a long-lived object. Failing to clean up thenotificationlistener results in a memory leak in the event that many ephemeral streams are created with the sameengine-- for example, extension popups or browser tabs. This fixes the issue.