-
-
Notifications
You must be signed in to change notification settings - Fork 4
refactor!: Rewrite check changelog to action #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change otherwise the changes looks good to me!
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
| github-tools-ref: | ||
| description: 'The SHA of the action to use. Defaults to the current action ref, and usually does not need to be changed.' | ||
| required: false | ||
| default: ${{ github.action_ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Context expressions invalid in action input defaults
GitHub Actions metadata files (action.yml) do not support context expressions (like ${{ github.action_repository }}) in input default values. These will be interpreted as literal strings (e.g., "${{ github.action_repository }}"), causing the checkout step to fail. Remove the defaults and handle the fallback logic directly in the step inputs (e.g., repository: ${{ inputs.github-tools-repository || github.action_repository }}).
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This rewrites the check changelog workflow to an action, letting us use
github.action_repositoryandgithub.action_ref, removing the need for specifying an action ref.Note
Replaces the reusable workflow with a composite action for changelog checks, defaulting to current action repo/ref and updating checkout/setup steps.
/.github/actions/check-changelog/action.yml:base-branch,head-ref,labels,pr-number,repo, plusgithub-tools-repositoryandgithub-tools-ref(defaulting togithub.action_repositoryandgithub.action_ref)../.github-tools, enables Corepack, sets up Node via./.github-tools/.nvmrc, installs deps, and runschangelog:check./.github/workflows/changelog-check.yml.Written by Cursor Bugbot for commit 9d0012c. This will update automatically on new commits. Configure here.