generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Use environment variables for script inputs in all workflows #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Nov 19, 2025
Comment on lines
197
to
202
| - name: Get Corepack install command | ||
| env: | ||
| YARN_VERSION: ${{ inputs.yarn-version }} | ||
| shell: bash | ||
| run: | | ||
| echo "COREPACK_COMMAND=corepack enable && corepack prepare yarn@$YARN_VERSION" >> "$GITHUB_OUTPUT" |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how nick-fields/retry uses the command below, so added this just in case.
cryptodev-2s
approved these changes
Nov 19, 2025
Contributor
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding script inputs in the bash script directly, we can use environment variables.
Note
Replaces inline input interpolation with environment variables and step outputs across actions/workflows, simplifying scripts and standardizing parameter handling (and removes a redundant step in PR line check).
envand consume$VARSin runs.BASE_BRANCHvia env; read change counts and thresholds from env ingithub-script.is-high-risk-environmentviaIS_HIGH_RISK_ENVIRONMENTenv var.TARGETandAWS_REGIONenv vars when selecting secret and fetching from AWS.UPLOAD_PATHandS3_BUCKETenv vars for S3 copy commands.Written by Cursor Bugbot for commit 895a557. This will update automatically on new commits. Configure here.