Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 19, 2025

Instead of adding script inputs in the bash script directly, we can use environment variables.


Note

Replaces inline input interpolation with environment variables and step outputs across actions/workflows, simplifying scripts and standardizing parameter handling (and removes a redundant step in PR line check).

  • Workflows:
    • create-release-pr / update-release-changelog / stable-sync / main / lint-workflows: Move script arguments and references to env vars; pass inputs via env and consume $VARS in runs.
    • pr-line-check: Remove separate base-branch resolution step; set BASE_BRANCH via env; read change counts and thresholds from env in github-script.
  • Composite Actions:
    • checkout-and-setup: Validate is-high-risk-environment via IS_HIGH_RISK_ENVIRONMENT env var.
    • configure-keystore: Use TARGET and AWS_REGION env vars when selecting secret and fetching from AWS.
    • setup-e2e-env: Use env vars for Android AVD/image params, Yarn install command via a step output, Foundry and Xcode versions via env.
    • upload-s3: Use UPLOAD_PATH and S3_BUCKET env vars for S3 copy commands.

Written by Cursor Bugbot for commit 895a557. This will update automatically on new commits. Configure here.

Comment on lines 197 to 202
- name: Get Corepack install command
env:
YARN_VERSION: ${{ inputs.yarn-version }}
shell: bash
run: |
echo "COREPACK_COMMAND=corepack enable && corepack prepare yarn@$YARN_VERSION" >> "$GITHUB_OUTPUT"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how nick-fields/retry uses the command below, so added this just in case.

@Mrtenz Mrtenz marked this pull request as ready for review November 19, 2025 14:40
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit f4b2aa8 into main Nov 19, 2025
19 checks passed
@Mrtenz Mrtenz deleted the mrtenz/env-vars branch November 19, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants