devDeps/test: ganache-core->ganache-cli #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
devdeps-fix-install
branch
from
89dbf2b to
67cb2fd
Compare
The supplied version has a broken dependency specification for frozeman/WebSocket-Node and therefore does not install at all. ganache-core has itself been superceded by ganache-cli and later ganacher, which both provide compatible interfaces. ganache-cli is in fact also deprecated, but the replacement ganache depends on a version of leveldown not compatible with legacy nodejs versions. A future change should take the next step. This has been tested down to nodejs v8.17.0.
legobeat
force-pushed
the
devdeps-fix-install
branch
from
24c499e to
5023577
Compare
It pulls in base62@1.7.2, which calls to google analytics as part of installation. lockfile generated on nodejs@v8.17.0, npm@6.13.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supplied version has a broken dependency specification for frozeman/WebSocket-Node and therefore does not install at all. ganache-core has itself been superceded by ganache-cli and later ganacher, which both provide compatible interfaces.
ganache-cli is in fact also deprecated, but the replacement ganache depends on a version of leveldown not compatible with legacy nodejs versions. A future change should take the next step.
This has been tested down to nodejs v8.17.0.