Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.2.0 release #61

Merged
merged 2 commits into from
Sep 19, 2022
Merged

v2.2.0 release #61

merged 2 commits into from
Sep 19, 2022

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Sep 19, 2022

This release adds support for the Sepolia network

@ryanml ryanml self-assigned this Sep 19, 2022
@ryanml ryanml requested a review from a team as a code owner September 19, 2022 16:32
ryanml
ryanml commented Sep 19, 2022
View reviewed changes
CHANGELOG.md Outdated
## [2.1.0] - 2021-05-07
### Added

- Add methods (getBlockExplorerLink, getAccountLink, getTokenTrackerLink) that select correct block explorer link format based on input params ([#31](https://github.com/MetaMask/etherscan-link/pull/44))
- Add methods (getBlockExplorerLink, getAccountLink, getTokenTrackerLink) that select correct block explorer link format based on input params ([#44](https://github.com/MetaMask/etherscan-link/pull/44))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little link fix

Copy link
Contributor

@danjm danjm Sep 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing, and sorry for being annoying, but I think it would be best to leave this out, so that the release PR is only about the release and nothing else. Makes it easier for reverting if necessary, also makes tracking down information in the future easier. So I suggest opening a separate PR for this lint fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danjm no annoyance at all! :) Updated, will make a separate PR after this is merged.

NiranjanaBinoy
NiranjanaBinoy previously approved these changes Sep 19, 2022
View reviewed changes
Copy link

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danjm
danjm requested changes Sep 19, 2022
View reviewed changes
CHANGELOG.md Outdated
## [2.1.0] - 2021-05-07
### Added

- Add methods (getBlockExplorerLink, getAccountLink, getTokenTrackerLink) that select correct block explorer link format based on input params ([#31](https://github.com/MetaMask/etherscan-link/pull/44))
- Add methods (getBlockExplorerLink, getAccountLink, getTokenTrackerLink) that select correct block explorer link format based on input params ([#44](https://github.com/MetaMask/etherscan-link/pull/44))
Copy link
Contributor

@danjm danjm Sep 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing, and sorry for being annoying, but I think it would be best to leave this out, so that the release PR is only about the release and nothing else. Makes it easier for reverting if necessary, also makes tracking down information in the future easier. So I suggest opening a separate PR for this lint fix

@ryanml ryanml merged commit c974670 into main Sep 19, 2022
@ryanml ryanml deleted the release-v2.2.0 branch September 19, 2022 16:42
@brad-decker
Copy link
Contributor

A new version of the package @metamask/etherscan-link (2.2.0) was published at 2022-09-19T18:24:33.162Z from
[[REDACTED]] The shasum of this package was 76314d0c1405a0669fc4a0a19e0877bd3d0c389f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjm danjm danjm approved these changes

@adonesky1 adonesky1 Awaiting requested review from adonesky1

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanml @brad-decker @danjm @NiranjanaBinoy