Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bn.js@^4.12.0->^5.2.1 #117

Merged
merged 4 commits into from
Feb 5, 2024
Merged

deps: bn.js@^4.12.0->^5.2.1 #117

merged 4 commits into from
Feb 5, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Feb 2, 2024

Changed

  • Update bn.js from ^4.12.0 to ^5.2.1
  • Update @metamask/ethjs-contract from ^0.3.4 to ^0.4.1
    • This package has been upgraded from babel v6 to v7
  • Update @metamask/ethjs-query from ^0.5.2 to ^0.7.1
    • This package has been upgraded from babel v6 to v7 and bn.js v4 to v5

Fixed

  • Remove dependency on babel-runtime

Blocked by

Related

Copy link

socket-security bot commented Feb 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/ethjs-contract@0.4.1 None +14 4.08 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/@metamask/ethjs-query@0.7.1 None +13 2.25 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/bn.js@5.2.1 None 0 99 kB fanatid

🚮 Removed packages: npm/@metamask/ethjs-contract@0.3.4, npm/@metamask/ethjs-query@0.5.2

View full report↗︎

@legobeat legobeat mentioned this pull request Feb 2, 2024
1 task
Copy link

socket-security bot commented Feb 2, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/ethjs-contract@0.4.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat

This comment was marked as resolved.

@legobeat legobeat marked this pull request as ready for review February 2, 2024 18:29
@legobeat legobeat requested a review from a team as a code owner February 2, 2024 18:29
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Feb 2, 2024
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question below.

package.json Outdated Show resolved Hide resolved
@mcmire mcmire mentioned this pull request Feb 2, 2024
@legobeat legobeat requested a review from mcmire February 3, 2024 10:02
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@legobeat legobeat merged commit d636715 into MetaMask:main Feb 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants