Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 26, 2023

Bumps @metamask/utils from 5.0.1 to 5.0.2.

Release notes

Sourced from @​metamask/utils's releases.

5.0.2

Changed

  • The Keyring exposes a new optional method init (#99)

Fixed

  • Bump @ethereumjs/tx to 4.1.2 to address runtime compatibility issues (#100)
Changelog

Sourced from @​metamask/utils's changelog.

[5.0.2]

Changed

  • The Keyring exposes a new optional method init (#99)

Fixed

  • Bump @ethereumjs/tx to 4.1.2 to address runtime compatibility issues (#100)
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @legobeat.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner April 26, 2023 06:58
@dependabot dependabot bot added the type-dependencies Pull requests that update a dependency file label Apr 26, 2023
legobeat

This comment was marked as outdated.

@legobeat legobeat self-requested a review April 26, 2023 07:39
@legobeat
Copy link
Contributor

Needs type update:

Error: src/simple-keyring.ts(82,9): error TS2416: Property 'signTransaction' in type 'SimpleKeyring' is not assignable to the same property in base type 'Keyring<string[]>'.
  Type '(address: `0x${string}`, transaction: TypedTransaction, opts?: KeyringOpt) => Promise<TypedTransaction>' is not assignable to type '(address: `0x${string}`, transaction: TypedTransaction, options?: Record<string, unknown> | undefined) => Promise<TxData>'.
    Types of parameters 'transaction' and 'transaction' are incompatible.
      Type 'import("/home/runner/work/eth-simple-keyring/eth-simple-keyring/node_modules/@metamask/utils/node_modules/@ethereumjs/tx/dist/types").TypedTransaction' is not assignable to type 'import("/home/runner/work/eth-simple-keyring/eth-simple-keyring/node_modules/@ethereumjs/tx/dist/types").TypedTransaction' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
        Type 'AccessListEIP2930Transaction' is not assignable to type 'TypedTransaction' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
          Type 'import("/home/runner/work/eth-simple-keyring/eth-simple-keyring/node_modules/@metamask/utils/node_modules/@ethereumjs/tx/dist/eip2930Transaction").AccessListEIP2930Transaction' is not assignable to type 'import("/home/runner/work/eth-simple-keyring/eth-simple-keyring/node_modules/@ethereumjs/tx/dist/eip2930Transaction").AccessListEIP2930Transaction' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
            Types of property 'common' are incompatible.
              Type 'import("/home/runner/work/eth-simple-keyring/eth-simple-keyring/node_modules/@ethereumjs/common/dist/common").Common' is not assignable to type 'import("/home/runner/work/eth-simple-keyring/eth-simple-keyring/node_modules/@ethereumjs/tx/node_modules/@ethereumjs/common/dist/common").Common'.
                Types have separate declarations of a private property '_chainParams'.

https://github.com/MetaMask/eth-simple-keyring/actions/runs/4805807427/jobs/8552614744?pr=142

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/utils-5.0.2 branch from 518d1e0 to 410a821 Compare April 28, 2023 07:49
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 28, 2023

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@legobeat
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/utils-5.0.2 branch from 410a821 to fc5b5d5 Compare April 28, 2023 07:54
Bumps [@metamask/utils](https://github.com/MetaMask/utils) from 5.0.1 to 5.0.2.
- [Release notes](https://github.com/MetaMask/utils/releases)
- [Changelog](https://github.com/MetaMask/utils/blob/main/CHANGELOG.md)
- [Commits](MetaMask/utils@v5.0.1...v5.0.2)

---
updated-dependencies:
- dependency-name: "@metamask/utils"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/utils-5.0.2 branch from fc5b5d5 to 268017c Compare May 2, 2023 12:42
@legobeat
Copy link
Contributor

legobeat commented Sep 1, 2023


  ● simple-keyring › #signMessage › throw error for invalid message

    expect(received).rejects.toThrow()

    Received promise resolved instead of rejected
    Resolved to value: "0xd96d76923f9697c69d8f82e719b6363cb4c38f654ad6ce0985be9cde9b44781357b8761e465f983cd28c5296bed186242aa56456deb69114d26ce1af3deb9d541c"

      192 |     it('throw error for invalid message', async function () {
      193 |       await keyring.deserialize([privateKey]);
    > 194 |       await expect(keyring.signMessage(address, '')).rejects.toThrow(
          |             ^
      195 |         'Cannot convert 0x to a BigInt',
      196 |       );
      197 |     });

      at expect (node_modules/expect/build/index.js:105:15)
      at Object.<anonymous> (src/simple-keyring.test.ts:194:13)

@legobeat
Copy link
Contributor

legobeat commented Sep 1, 2023

Blocked by #148

@legobeat
Copy link
Contributor

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 12, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@legobeat
Copy link
Contributor

Superseded by #155

@legobeat legobeat closed this Sep 12, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 12, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/metamask/utils-5.0.2 branch September 12, 2023 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type-dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant