Skip to content

Fix normalize for empty strings #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikesposito merged 2 commits into from
Jun 26, 2023
Merged

Fix normalize for empty strings #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39fd8b7
fix: normalize should also work with empty strings
mikesposito Jun 22, 2023
1f289d3
test: add test for empty string normalization
mikesposito Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ describe('normalize', function () {
expect(result).toBe('0x');
});

it('should normalize an empty string to 0x', function () {
const initial = '';
const result = normalize(initial);
expect(result).toBe('0x');
});

// TODO: Add validation to disallow null.
it('should return undefined if given null', function () {
const initial = null;
Expand Down
2 changes: 1 addition & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function recoverPublicKey(
* @returns The normalized value.
*/
export function normalize(input: number | string): string | undefined {
if (!input) {
if (isNullish(input)) {
return undefined;
}

Expand Down