Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0.1 #279

Merged
merged 5 commits into from
Nov 9, 2022
Merged

5.0.1 #279

merged 5 commits into from
Nov 9, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 9, 2022 •
edited by adonesky1
Loading

This is the release candidate for version 5.0.1.

[5.0.1]

Added

  • Add additional tests to cover encoded data values that were not previously covered which led to unintended changes to encoding hexstrings in v5.0.0 (#274)

Fixed

  • Fix issue introduced in v5.0.0 where the encodeField encoded fields typed as bytes and passed as a hexstring was encoded differently than previous versions (#271, #274)

github-actions and others added 2 commits November 9, 2022 22:26
@adonesky1 adonesky1 marked this pull request as ready for review November 9, 2022 22:27
@adonesky1 adonesky1 requested a review from a team as a code owner November 9, 2022 22:27
Gudahtt
Gudahtt reviewed Nov 9, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Gudahtt
Gudahtt reviewed Nov 9, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
adonesky1 and others added 2 commits November 9, 2022 16:33
@adonesky1 @Gudahtt
Update CHANGELOG.md
96772c3 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@adonesky1 @Gudahtt
Update CHANGELOG.md
3396ae3 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
adonesky1
adonesky1 reviewed Nov 9, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Gudahtt
Gudahtt approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit f62368d into main Nov 9, 2022
@adonesky1 adonesky1 deleted the release/5.0.1 branch November 9, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 left review comments

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gudahtt @adonesky1